You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by AhyoungRyu <gi...@git.apache.org> on 2016/12/15 07:47:47 UTC

[GitHub] zeppelin pull request #1766: [MINOR] Set default interpreter \w first intp

GitHub user AhyoungRyu opened a pull request:

    https://github.com/apache/zeppelin/pull/1766

    [MINOR] Set default interpreter \w first intp

    ### What is this PR for?
    Currently we can select default interpreter when we create a new note like below.
    ![screen shot 2016-12-15 at 4 41 15 pm](https://cloud.githubusercontent.com/assets/10060731/21215571/56bf4078-c2e5-11e6-8455-b2cb0e126007.png)
    
    However, even if we don't set the default interpreter(don't select any interpreters) in this dialog and just create new note, the default interpreter is automatically set as `Spark` interpreter. This can be checked in the interpreter binding page. It doesn't make sense I think. 
    So I removed `--select--` and set the default option in the select box with `Spark` as the interpreter binding page does. 
    
    ### What type of PR is it?
    Bug Fix
    
    ### What is the Jira issue?
    N/A
    
    ### How should this be tested?
    1. Build only web \w `npm run build` under `zeppelin-web/` and run `npm run start` for dev mode. 
    2. Create a new note and see the select box 
    
    or just see the below screenshots :)
    
    ### Screenshots (if appropriate)
     - Before 
    ![before](https://cloud.githubusercontent.com/assets/10060731/21215524/1b3f9886-c2e5-11e6-9947-e9186e087b54.gif)
    
     - After
    ![default_intp](https://cloud.githubusercontent.com/assets/10060731/21215526/1cc8d258-c2e5-11e6-9a71-504f7164078b.gif)
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/AhyoungRyu/zeppelin fix-default-intp

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1766.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1766
    
----
commit 569e63bf27180c81beb0d35faabf477714fa4fec
Author: AhyoungRyu <fb...@hanmail.net>
Date:   2016-12-15T07:32:13Z

    Set default interpreter \w first intp

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1766: [MINOR] Set default interpreter \w first intp

Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:

    https://github.com/apache/zeppelin/pull/1766
  
    @zjffdu @Leemoonsoo Thanks for your review! 
    Will merge into master if there are no more comments. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1766: [MINOR] Set default interpreter \w first intp

Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/1766
  
    lgtm


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1766: [MINOR] Set default interpreter \w first intp

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/1766
  
    LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1766: [MINOR] Set default interpreter \w first intp

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/1766


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---