You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2015/06/19 01:15:55 UTC

Review Request 35633: Fixing stylecheck errors.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35633/
-----------------------------------------------------------

Review request for Aurora and Bill Farner.


Repository: aurora


Description
-------

Looks like regression from: https://reviews.apache.org/r/35627/


Diffs
-----

  src/main/java/org/apache/aurora/auth/UnsecureAuthModule.java 010e7146799381518436d410ce8272edbe3e0df9 
  src/main/java/org/apache/aurora/auth/UnsecureSessionContext.java 0226144ffecec611200077e3ec66ede6cee58a3a 
  src/test/java/org/apache/aurora/auth/UnsecureSessionContextTest.java a8badd40f63433216d809cbbebe79c15c9427571 

Diff: https://reviews.apache.org/r/35633/diff/


Testing
-------


Thanks,

Maxim Khutornenko


Re: Review Request 35633: Fixing stylecheck errors.

Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35633/#review88456
-----------------------------------------------------------

Ship it!


Ship It!

- Bill Farner


On June 18, 2015, 11:15 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35633/
> -----------------------------------------------------------
> 
> (Updated June 18, 2015, 11:15 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Looks like regression from: https://reviews.apache.org/r/35627/
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/auth/UnsecureAuthModule.java 010e7146799381518436d410ce8272edbe3e0df9 
>   src/main/java/org/apache/aurora/auth/UnsecureSessionContext.java 0226144ffecec611200077e3ec66ede6cee58a3a 
>   src/test/java/org/apache/aurora/auth/UnsecureSessionContextTest.java a8badd40f63433216d809cbbebe79c15c9427571 
> 
> Diff: https://reviews.apache.org/r/35633/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Re: Review Request 35633: Fixing stylecheck errors.

Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35633/#review88465
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Sweeney


On June 18, 2015, 4:15 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35633/
> -----------------------------------------------------------
> 
> (Updated June 18, 2015, 4:15 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Looks like regression from: https://reviews.apache.org/r/35627/
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/auth/UnsecureAuthModule.java 010e7146799381518436d410ce8272edbe3e0df9 
>   src/main/java/org/apache/aurora/auth/UnsecureSessionContext.java 0226144ffecec611200077e3ec66ede6cee58a3a 
>   src/test/java/org/apache/aurora/auth/UnsecureSessionContextTest.java a8badd40f63433216d809cbbebe79c15c9427571 
> 
> Diff: https://reviews.apache.org/r/35633/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>