You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2023/07/14 07:21:59 UTC
[GitHub] [arrow] kou opened a new pull request, #36681: GH-36680: [C++] Add missing ARROW_ACERO dependency to ARROW_PYTHON
kou opened a new pull request, #36681:
URL: https://github.com/apache/arrow/pull/36681
### Rationale for this change
PyArrow wants Acero.
### What changes are included in this PR?
Add `ARROW_ACERO` to `ARROW_PYTHON` dependency.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #36681: GH-36680: [C++] Add missing ARROW_ACERO dependency to ARROW_PYTHON
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #36681:
URL: https://github.com/apache/arrow/pull/36681#issuecomment-1635469576
@github-actions crossbow submit example-python-minimal-*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #36681: GH-36680: [C++] Add missing ARROW_ACERO dependency to ARROW_PYTHON
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #36681:
URL: https://github.com/apache/arrow/pull/36681#issuecomment-1636886716
I withdraw this because this is needless.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #36681: GH-36680: [C++] Add missing ARROW_ACERO dependency to ARROW_PYTHON
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #36681:
URL: https://github.com/apache/arrow/pull/36681#discussion_r1264561084
##########
cpp/cmake_modules/DefineOptions.cmake:
##########
@@ -387,6 +387,7 @@ takes precedence over ccache if a storage backend is configured" ON)
(This is a deprecated option. Use CMake presets instead.)"
OFF
DEPENDS
+ ARROW_ACERO
Review Comment:
Sorry. This is needless.
I thought that this is the cause of #36680 but it was wrong: #36683
I thought that this is still needed because #34711 removes `ARROW_COMPUTE` from `ARROW_PYTHON` instead of replacing `ARROW_COMPUTE` with `ARROW_ACERO`.
But it's correct because `ARROW_PYTHON` depends on `ARROW_ACERO` explicitly: `ARROW_PYTHON` -> `ARROW_DATASET` -> `ARROW_ACERO`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #36681: GH-36680: [C++] Add missing ARROW_ACERO dependency to ARROW_PYTHON
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #36681:
URL: https://github.com/apache/arrow/pull/36681#issuecomment-1635415272
@github-actions crossbow submit example-python-minimal-*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #36681: GH-36682: [C++] Add missing ARROW_ACERO dependency to ARROW_PYTHON
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #36681:
URL: https://github.com/apache/arrow/pull/36681#discussion_r1264561084
##########
cpp/cmake_modules/DefineOptions.cmake:
##########
@@ -387,6 +387,7 @@ takes precedence over ccache if a storage backend is configured" ON)
(This is a deprecated option. Use CMake presets instead.)"
OFF
DEPENDS
+ ARROW_ACERO
Review Comment:
Sorry. This is needless.
I thought that this is the cause of #36680 but it was wrong: #36683
I thought that this is still needed because #34711 removes `ARROW_COMPUTE` from `ARROW_PYTHON` instead of replacing `ARROW_COMPUTE` with `ARROW_ACERO`.
But it's correct because `ARROW_PYTHON` depends on `ARROW_ACERO` implicitly: `ARROW_PYTHON` -> `ARROW_DATASET` -> `ARROW_ACERO`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on a diff in pull request #36681: GH-36680: [C++] Add missing ARROW_ACERO dependency to ARROW_PYTHON
Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche commented on code in PR #36681:
URL: https://github.com/apache/arrow/pull/36681#discussion_r1263680273
##########
cpp/cmake_modules/DefineOptions.cmake:
##########
@@ -387,6 +387,7 @@ takes precedence over ccache if a storage backend is configured" ON)
(This is a deprecated option. Use CMake presets instead.)"
OFF
DEPENDS
+ ARROW_ACERO
Review Comment:
Also, shouldn't we in theory _not_ rely on this in our own CI, given that it is a deprecated option?
If the minimal python build needs this, then we should just enable ARROW_ACERO directly in that build? (or update it to not require acero)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #36681: GH-36680: [C++] Add missing ARROW_ACERO dependency to ARROW_PYTHON
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #36681:
URL: https://github.com/apache/arrow/pull/36681#issuecomment-1635484481
I've opened #36683 for the `example-minimal-python-*` failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on a diff in pull request #36681: GH-36680: [C++] Add missing ARROW_ACERO dependency to ARROW_PYTHON
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on code in PR #36681:
URL: https://github.com/apache/arrow/pull/36681#discussion_r1263560910
##########
cpp/cmake_modules/DefineOptions.cmake:
##########
@@ -387,6 +387,7 @@ takes precedence over ccache if a storage backend is configured" ON)
(This is a deprecated option. Use CMake presets instead.)"
OFF
DEPENDS
+ ARROW_ACERO
Review Comment:
I am not entirely sure why are we doing this change. Should all ARROW_PYTHON dependencies be added? what about S3 or GCS?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #36681: GH-36680: [C++] Add missing ARROW_ACERO dependency to ARROW_PYTHON
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36681:
URL: https://github.com/apache/arrow/pull/36681#issuecomment-1635418762
Revision: fe14c3f5466c3ad871f8b46e524d88bcc5dc1799
Submitted crossbow builds: [ursacomputing/crossbow @ actions-0c9885ed6b](https://github.com/ursacomputing/crossbow/branches/all?query=actions-0c9885ed6b)
|Task|Status|
|----|------|
|example-python-minimal-build-fedora-conda|[](https://github.com/ursacomputing/crossbow/actions/runs/5551590228/jobs/10137896500)|
|example-python-minimal-build-ubuntu-venv|[](https://github.com/ursacomputing/crossbow/actions/runs/5551590487/jobs/10137896875)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on a diff in pull request #36681: GH-36680: [C++] Add missing ARROW_ACERO dependency to ARROW_PYTHON
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on code in PR #36681:
URL: https://github.com/apache/arrow/pull/36681#discussion_r1263560910
##########
cpp/cmake_modules/DefineOptions.cmake:
##########
@@ -387,6 +387,7 @@ takes precedence over ccache if a storage backend is configured" ON)
(This is a deprecated option. Use CMake presets instead.)"
OFF
DEPENDS
+ ARROW_ACERO
Review Comment:
I am not entirely sure I understand why are we doing this change. Should all ARROW_PYTHON dependencies be added? what about S3 or GCS?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #36681: GH-36682: [C++] Add missing ARROW_ACERO dependency to ARROW_PYTHON
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36681:
URL: https://github.com/apache/arrow/pull/36681#issuecomment-1636886921
:warning: GitHub issue #36682 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #36681: GH-36680: [C++] Add missing ARROW_ACERO dependency to ARROW_PYTHON
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36681:
URL: https://github.com/apache/arrow/pull/36681#issuecomment-1635415492
:warning: GitHub issue #36680 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou closed pull request #36681: GH-36680: [C++] Add missing ARROW_ACERO dependency to ARROW_PYTHON
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou closed pull request #36681: GH-36680: [C++] Add missing ARROW_ACERO dependency to ARROW_PYTHON
URL: https://github.com/apache/arrow/pull/36681
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #36681: GH-36680: [C++] Add missing ARROW_ACERO dependency to ARROW_PYTHON
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36681:
URL: https://github.com/apache/arrow/pull/36681#issuecomment-1635472710
Revision: 34f72d9d3d3d87871a9290897359c5065d4eee94
Submitted crossbow builds: [ursacomputing/crossbow @ actions-b4ca64b29f](https://github.com/ursacomputing/crossbow/branches/all?query=actions-b4ca64b29f)
|Task|Status|
|----|------|
|example-python-minimal-build-fedora-conda|[](https://github.com/ursacomputing/crossbow/actions/runs/5551945046/jobs/10138671446)|
|example-python-minimal-build-ubuntu-venv|[](https://github.com/ursacomputing/crossbow/actions/runs/5551945255/jobs/10138671751)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org