[GitHub] [doris] yiguolei commented on a diff in pull request #21027: [fix](log) fix the too large warning log of BE

["yiguolei (via GitHub)" <gi...@apache.org>]

yiguolei commented on code in PR #21027:
URL: https://github.com/apache/doris/pull/21027#discussion_r1235439278


##########
be/src/pipeline/pipeline_task.cpp:
##########
@@ -335,15 +336,20 @@ std::string PipelineTask::debug_string() {
         fmt::format_to(debug_string_buffer, "\n{}{}", std::string(i * 2, ' '),
                        _operators[i]->debug_string());
         std::stringstream profile_ss;
-        _operators[i]->get_runtime_profile()->pretty_print(&profile_ss, std::string(i * 2, ' '));
+        if (config::enable_detail_failed_log) {
+            _operators[i]->get_runtime_profile()->pretty_print(&profile_ss,
+                                                               std::string(i * 2, ' '));
+        }
         fmt::format_to(debug_string_buffer, "\n{}", profile_ss.str());
     }
     fmt::format_to(debug_string_buffer, "\n{}{}", std::string(_operators.size() * 2, ' '),
                    _sink->debug_string());
     {
         std::stringstream profile_ss;
-        _sink->get_runtime_profile()->pretty_print(&profile_ss,
-                                                   std::string(_operators.size() * 2, ' '));
+        if (config::enable_detail_failed_log) {

Review Comment:
   这种config 都没什么意义，如果大家都这么搞config，还用vlog 这种干啥呢



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org