You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/07/29 08:47:21 UTC

[GitHub] [cloudstack] ravening commented on a change in pull request #4678: Support mutiple management networks in systemvms

ravening commented on a change in pull request #4678:
URL: https://github.com/apache/cloudstack/pull/4678#discussion_r678952401



##########
File path: systemvm/debian/opt/cloud/bin/setup/common.sh
##########
@@ -322,7 +322,12 @@ setup_common() {
 
   if [ -n "$MGMTNET"  -a -n "$LOCAL_GW" ]
   then
-    ip route add $MGMTNET via $LOCAL_GW dev eth1
+    log_it "Received mgmt cidr : $MGMTNET"
+    cidrs=(${MGMTNET//,/ })
+    for cidr in ${cidrs[@]}
+    do
+      ip route add $cidr dev eth1

Review comment:
       > @ravening I am wondering why there is no "via gateway" in route.
   
   @weizhouapache do we need the "via gateway" ? it was not there in the original change




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org