[GitHub] [hbase] ndimiduk commented on a change in pull request #1124: HBASE-23792 [Flakey Test] TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState

[GitBox <gi...@apache.org>]

ndimiduk commented on a change in pull request #1124: HBASE-23792 [Flakey Test] TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState
URL: https://github.com/apache/hbase/pull/1124#discussion_r374993219
 
 

 ##########
 File path: hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/snapshot/TestExportSnapshotNoCluster.java
 ##########
 @@ -67,29 +64,29 @@ public static void setUpBaseConf(Configuration conf) {
     conf.set(HConstants.HBASE_DIR, testDir.toString());
   }
 
-  @BeforeClass
-  public static void setUpBeforeClass() throws Exception {
+  @Before
+  public void setUpBefore() throws Exception {
     // Make sure testDir is on LocalFileSystem
-    testDir = TEST_UTIL.getDataTestDir().makeQualified(URI.create("file:///"), new Path("/"));
-    fs = testDir.getFileSystem(TEST_UTIL.getConfiguration());
+    testDir = testUtil.getDataTestDir().makeQualified(URI.create("file:///"), new Path("/"));
 
 Review comment:
   `testUtil.getDataTestDir()` will generate a path with a random UUID, so by getting a fresh instance of `testUtil`, I get an isolated path.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services