[GitHub] [ozone] smengcl commented on pull request #4125: HDDS-7277. [Snapshot] Implement snapshot key listing in Ozone Shell

["smengcl (via GitHub)" <gi...@apache.org>]

smengcl commented on PR #4125:
URL: https://github.com/apache/ozone/pull/4125#issuecomment-1414419236

   > @hemantk-12 Would [this approach](https://github.com/xBis7/ozone/blob/5509ccd365232933fc51c0a688a61a4e2d5d4699/hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/snapshot/ListSnapshotKeyHandler.java) seem cleaner? That's from commit [5509ccd](https://github.com/apache/ozone/commit/5509ccd365232933fc51c0a688a61a4e2d5d4699).
   
   Hi @xBis7 , looks like this approach is add a brand new subcommand to Ozone Shell? If this is the case it is not desired, as we do want a unified interface for listing under regular buckets and snapshotted ones.
   
   On the other hand, I agree with @hemantk-12 that we should try to keep using the previous `BucketHandler` [here](https://github.com/apache/ozone/pull/4125#discussion_r1084605774). Or maybe we could rename `SnapshotHandler` into something like `BucketAndSnapshotHandler` in order not to give the wrong impression?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org