You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2018/06/22 21:48:00 UTC
Review Request 67709: Added two tests to the stout cmake build.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67709/
-----------------------------------------------------------
Review request for mesos and Andrew Schwartzmeyer.
Repository: mesos
Description
-------
Added two tests to the stout cmake build.
Diffs
-----
3rdparty/stout/tests/CMakeLists.txt 7c644b7248de86d9f255f7d6914fb01cb1907e62
Diff: https://reviews.apache.org/r/67709/diff/1/
Testing
-------
`make check` (cmake)
`./support/mesos-tidy.sh`
Thanks,
Benjamin Bannier
Re: Review Request 67709: Added two tests to the stout cmake build.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67709/#review205259
-----------------------------------------------------------
PASS: Mesos patch 67709 was successfully built and tested.
Reviews applied: `['67707', '67708', '67709']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67709
- Mesos Reviewbot Windows
On June 22, 2018, 9:48 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67709/
> -----------------------------------------------------------
>
> (Updated June 22, 2018, 9:48 p.m.)
>
>
> Review request for mesos and Andrew Schwartzmeyer.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added two tests to the stout cmake build.
>
>
> Diffs
> -----
>
> 3rdparty/stout/tests/CMakeLists.txt 7c644b7248de86d9f255f7d6914fb01cb1907e62
>
>
> Diff: https://reviews.apache.org/r/67709/diff/1/
>
>
> Testing
> -------
>
> `make check` (cmake)
> `./support/mesos-tidy.sh`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 67709: Added two tests to the stout cmake build.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67709/#review205261
-----------------------------------------------------------
Patch looks great!
Reviews applied: [67707, 67708, 67709]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On June 22, 2018, 2:48 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67709/
> -----------------------------------------------------------
>
> (Updated June 22, 2018, 2:48 p.m.)
>
>
> Review request for mesos and Andrew Schwartzmeyer.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added two tests to the stout cmake build.
>
>
> Diffs
> -----
>
> 3rdparty/stout/tests/CMakeLists.txt 7c644b7248de86d9f255f7d6914fb01cb1907e62
>
>
> Diff: https://reviews.apache.org/r/67709/diff/1/
>
>
> Testing
> -------
>
> `make check` (cmake)
> `./support/mesos-tidy.sh`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 67709: Added two tests to the stout cmake build.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67709/#review205318
-----------------------------------------------------------
Ship it!
Ship It!
- Andrew Schwartzmeyer
On June 22, 2018, 2:48 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67709/
> -----------------------------------------------------------
>
> (Updated June 22, 2018, 2:48 p.m.)
>
>
> Review request for mesos and Andrew Schwartzmeyer.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added two tests to the stout cmake build.
>
>
> Diffs
> -----
>
> 3rdparty/stout/tests/CMakeLists.txt 7c644b7248de86d9f255f7d6914fb01cb1907e62
>
>
> Diff: https://reviews.apache.org/r/67709/diff/1/
>
>
> Testing
> -------
>
> `make check` (cmake)
> `./support/mesos-tidy.sh`
>
>
> Thanks,
>
> Benjamin Bannier
>
>