You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2018/09/06 22:39:57 UTC
Review Request 68662: Avoided double copying of outgoing messages in
the master.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68662/
-----------------------------------------------------------
Review request for mesos, Gastón Kleiman, Gilbert Song, and Greg Mann.
Bugs: MESOS-9213
https://issues.apache.org/jira/browse/MESOS-9213
Repository: mesos
Description
-------
When framework metrics were introduced, there was an evolve + devolve
conversion occuring in order to map old style messages to the new
`scheduler::Event::Type`. This results in copying all outgoing
messages twice.
This patch avoids the copying by adding overloads for the old style
messages.
Diffs
-----
src/master/master.hpp ec2ae01ec813ff7fcb0e2a3d0dbad3c3f9993a98
src/master/metrics.hpp 14f894a40e96be93037e0d262ddc4b04a6fcc301
src/master/metrics.cpp 655c75a042a3bfeb264a55d7495f957c407a4d6d
Diff: https://reviews.apache.org/r/68662/diff/1/
Testing
-------
make check
Thanks,
Benjamin Mahler
Re: Review Request 68662: Avoided double copying of outgoing messages
in the master.
Posted by Benjamin Mahler <bm...@apache.org>.
> On Sept. 7, 2018, midnight, Gastón Kleiman wrote:
> > src/master/metrics.hpp
> > Lines 243 (patched)
> > <https://reviews.apache.org/r/68662/diff/1/?file=2086334#file2086334line243>
> >
> > This kind message is not sent to v0 schedulers, so we should take it out.
Chatted with Gastón offline, we weren't able to take this out because it's a run-time invariant. We could remove this if we update the master code to avoid calling it by checking its invariants and upgrading into an Event.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68662/#review208431
-----------------------------------------------------------
On Sept. 6, 2018, 10:39 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68662/
> -----------------------------------------------------------
>
> (Updated Sept. 6, 2018, 10:39 p.m.)
>
>
> Review request for mesos, Gastón Kleiman, Gilbert Song, and Greg Mann.
>
>
> Bugs: MESOS-9213
> https://issues.apache.org/jira/browse/MESOS-9213
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When framework metrics were introduced, there was an evolve + devolve
> conversion occuring in order to map old style messages to the new
> `scheduler::Event::Type`. This results in copying all outgoing
> messages twice.
>
> This patch avoids the copying by adding overloads for the old style
> messages.
>
>
> Diffs
> -----
>
> src/master/master.hpp ec2ae01ec813ff7fcb0e2a3d0dbad3c3f9993a98
> src/master/metrics.hpp 14f894a40e96be93037e0d262ddc4b04a6fcc301
> src/master/metrics.cpp 655c75a042a3bfeb264a55d7495f957c407a4d6d
>
>
> Diff: https://reviews.apache.org/r/68662/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 68662: Avoided double copying of outgoing messages
in the master.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68662/#review208431
-----------------------------------------------------------
Fix it, then Ship it!
src/master/metrics.hpp
Lines 243 (patched)
<https://reviews.apache.org/r/68662/#comment292340>
This kind message is not sent to v0 schedulers, so we should take it out.
- Gastón Kleiman
On Sept. 6, 2018, 3:39 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68662/
> -----------------------------------------------------------
>
> (Updated Sept. 6, 2018, 3:39 p.m.)
>
>
> Review request for mesos, Gastón Kleiman, Gilbert Song, and Greg Mann.
>
>
> Bugs: MESOS-9213
> https://issues.apache.org/jira/browse/MESOS-9213
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When framework metrics were introduced, there was an evolve + devolve
> conversion occuring in order to map old style messages to the new
> `scheduler::Event::Type`. This results in copying all outgoing
> messages twice.
>
> This patch avoids the copying by adding overloads for the old style
> messages.
>
>
> Diffs
> -----
>
> src/master/master.hpp ec2ae01ec813ff7fcb0e2a3d0dbad3c3f9993a98
> src/master/metrics.hpp 14f894a40e96be93037e0d262ddc4b04a6fcc301
> src/master/metrics.cpp 655c75a042a3bfeb264a55d7495f957c407a4d6d
>
>
> Diff: https://reviews.apache.org/r/68662/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 68662: Avoided double copying of outgoing messages
in the master.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68662/#review208432
-----------------------------------------------------------
Fix it, then Ship it!
src/master/metrics.hpp
Lines 231 (patched)
<https://reviews.apache.org/r/68662/#comment292341>
Nit: this comment sounds a bit awkward to me? Maybe something like:
"Overloads to convert old, unversioned scheduler messages into their event counterparts."
- Greg Mann
On Sept. 6, 2018, 10:39 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68662/
> -----------------------------------------------------------
>
> (Updated Sept. 6, 2018, 10:39 p.m.)
>
>
> Review request for mesos, Gastón Kleiman, Gilbert Song, and Greg Mann.
>
>
> Bugs: MESOS-9213
> https://issues.apache.org/jira/browse/MESOS-9213
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When framework metrics were introduced, there was an evolve + devolve
> conversion occuring in order to map old style messages to the new
> `scheduler::Event::Type`. This results in copying all outgoing
> messages twice.
>
> This patch avoids the copying by adding overloads for the old style
> messages.
>
>
> Diffs
> -----
>
> src/master/master.hpp ec2ae01ec813ff7fcb0e2a3d0dbad3c3f9993a98
> src/master/metrics.hpp 14f894a40e96be93037e0d262ddc4b04a6fcc301
> src/master/metrics.cpp 655c75a042a3bfeb264a55d7495f957c407a4d6d
>
>
> Diff: https://reviews.apache.org/r/68662/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 68662: Avoided double copying of outgoing messages
in the master.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68662/#review208434
-----------------------------------------------------------
PASS: Mesos patch 68662 was successfully built and tested.
Reviews applied: `['68662']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2306/mesos-review-68662
- Mesos Reviewbot Windows
On Sept. 6, 2018, 3:39 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68662/
> -----------------------------------------------------------
>
> (Updated Sept. 6, 2018, 3:39 p.m.)
>
>
> Review request for mesos, Gastón Kleiman, Gilbert Song, and Greg Mann.
>
>
> Bugs: MESOS-9213
> https://issues.apache.org/jira/browse/MESOS-9213
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When framework metrics were introduced, there was an evolve + devolve
> conversion occuring in order to map old style messages to the new
> `scheduler::Event::Type`. This results in copying all outgoing
> messages twice.
>
> This patch avoids the copying by adding overloads for the old style
> messages.
>
>
> Diffs
> -----
>
> src/master/master.hpp ec2ae01ec813ff7fcb0e2a3d0dbad3c3f9993a98
> src/master/metrics.hpp 14f894a40e96be93037e0d262ddc4b04a6fcc301
> src/master/metrics.cpp 655c75a042a3bfeb264a55d7495f957c407a4d6d
>
>
> Diff: https://reviews.apache.org/r/68662/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>