You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2009/07/01 00:28:49 UTC
[Bug 6141] New: fix "ALL:raw" pseudoheader to not modify header
whitespace at all
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6141
Summary: fix "ALL:raw" pseudoheader to not modify header
whitespace at all
Product: Spamassassin
Version: unspecified
Platform: Other
OS/Version: All
Status: NEW
Severity: enhancement
Priority: P5
Component: Libraries
AssignedTo: dev@spamassassin.apache.org
ReportedBy: jm@jmason.org
Created an attachment (id=4468)
--> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4468)
test that should pass
currently, the "ALL" pseudoheader will munge whitespace as described in bug
5673, and "ALL:raw" is exactly the same. this is suboptimal and we should fix
it, IMO.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6141] fix "ALL:raw" pseudoheader to not modify header
whitespace at all
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6141
--- Comment #2 from Justin Mason <jm...@jmason.org> 2009-08-05 02:11:13 PST ---
feel free! ;) fwiw I totally agree. it's a lack of round tuits that's the
problem.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6141] fix "ALL:raw" pseudoheader to not modify header
whitespace at all
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6141
Mark Martinec <Ma...@ijs.si> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P5 |P3
--- Comment #1 from Mark Martinec <Ma...@ijs.si> 2009-08-04 18:07:38 PST ---
I'd say now is the time for a change.
Once the 3.3.0 gets out, we'll be doomed for a long while again :)
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6141] fix "ALL:raw" pseudoheader to not modify header
whitespace at all
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6141
--- Comment #3 from Mark Martinec <Ma...@ijs.si> 2009-08-05 18:17:11 PST ---
> feel free! ;) fwiw I totally agree.
Bug 6141, Bug 5673:
- let "ALL:raw" pseudoheader return pristine headers, and
revert the semantics of "ALL" to return a cleaned header
section, i.e. reverting change in Node.pm by r607590;
- delay bailing out of parsing a header section on the
first invalid header field, it's to easily abusable;
add tests to t/missing_hb_separator.t accordingly;
- generalize parsing of modifiers like :raw and :addr
to allow multiple modifiers; document it;
- do not require a space after a colon while parsing
Received header fields;
- change a couple of get("ALL") to get("ALL:raw")
in PerMsgStatus.pm and in t/data/Dumpheaders.pm
to retain semantics;
- rules/20_head_tests.cf: change most of ALL to ALL:raw
to retain semantics; (should be reviewed to make sure
this is really what we want);
- 20_head_tests.cf, 20_ratware.cf: add regexp modifier /m
to several rules which use ^ or $ anchors to make it
harder to bypass these rules by providing multiple
header fields (e.g. double Subject or From). It is
almost always wrong (or irrelevant) to leave out
the /m modifier on header rules which use anchors.
Sending lib/Mail/SpamAssassin/Conf.pm
Sending lib/Mail/SpamAssassin/Message.pm
Sending lib/Mail/SpamAssassin/PerMsgStatus.pm
Sending rules/20_head_tests.cf
Sending rules/20_ratware.cf
Sending t/data/Dumpheaders.pm
Sending t/missing_hb_separator.t
Transmitting file data .......
Committed revision 801487 ( https://svn.apache.org/viewcvs.cgi?view=rev&rev=801487 ).
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6141] fix "ALL:raw" pseudoheader to not modify header
whitespace at all
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6141
--- Comment #4 from Justin Mason <jm...@jmason.org> 2009-08-06 01:50:14 PST ---
excellent! looks good to me. do you want to mark RESOLVED/FIXED, or re-aim to
3.2.x for a backport? (fwiw I'd say FIXED)
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6141] fix "ALL:raw" pseudoheader to not modify header
whitespace at all
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6141
Mark Martinec <Ma...@ijs.si> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #5 from Mark Martinec <Ma...@ijs.si> 2009-08-06 02:17:58 PST ---
> excellent! looks good to me. do you want to mark RESOLVED/FIXED,
> or re-aim to 3.2.x for a backport? (fwiw I'd say FIXED)
I wouldn't bother backporting it to 3.2. Closing.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.