[GitHub] [airflow] potiuk commented on a change in pull request #10433: Enhanced the Kubernetes Executor doc

[GitBox <gi...@apache.org>]

potiuk commented on a change in pull request #10433:
URL: https://github.com/apache/airflow/pull/10433#discussion_r474269862



##########
File path: docs/executor/kubernetes.rst
##########
@@ -44,15 +44,21 @@ KubernetesExecutor Architecture
 The KubernetesExecutor runs as a process in the Scheduler that only requires access to the Kubernetes API (it does *not* need to run inside of a Kubernetes cluster). The KubernetesExecutor requires a non-sqlite database in the backend, but there are no external brokers or persistent workers needed.
 For these reasons, we recommend the KubernetesExecutor for deployments have long periods of dormancy between DAG execution.
 
+When a DAG submits a task, the KubernetesExecutor requests a worker pod from the Kubernetes API. The worker pod then runs the task, reports the result, and terminates.
 
-.. image:: ../img/k8s-0-worker.jpeg
 
+.. image:: ../img/arch-diag-kubernetes.png

Review comment:
       I really appreciate the addition, but I think we should know how to reproduce the image in the future if we have to update it :). I really love things like mermaid - that can generate the image from markdown-ish text description and have everyone contribute to it easily. Maybe we can re-create the graphs with it . See  #10380 - mermaid has the capability of generating nice diagrams from the textual description which I think is crucial to get images that we can update in the future as a community effort.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org