[GitHub] [iceberg] kbendick commented on a diff in pull request #5228: Build - Add Git Properties Information via Plugin

[GitBox <gi...@apache.org>]

kbendick commented on code in PR #5228:
URL: https://github.com/apache/iceberg/pull/5228#discussion_r917052767


##########
build.gradle:
##########
@@ -73,6 +83,22 @@ subprojects {
   apply plugin: 'nebula.dependency-recommender'
   apply plugin: 'java-library'
 
+  // apply this plugin in a try-catch block so that we can handle cases without .git directory
+  // apply to subprojects so that git properties information is available for runtime debugging and tests
+  //  e.g. sending build SHA as headers
+  try {
+    apply plugin: 'com.gorylenko.gradle-git-properties'

Review Comment:
   From my testing, we would need it for local development or using a JAR built locally (such as copying over one `iceberg-core.jar` or even the spark bundle jar for local testing).
   
   But I can remove this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org