You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "X-LightYear (via GitHub)" <gi...@apache.org> on 2026/10/20 08:18:10 UTC
[PR] fix(rmqctl): create native Windows build output directory [rocketmq-dashboard]
X-LightYear opened a new pull request, #7244:
URL: https://github.com/apache/rocketmq-dashboard/pull/7244
## Summary
- create the parent directory for the native Windows build output
- keep the default clean-checkout build path `bin\\rmqctl.exe` usable
- add a Linux-runnable script contract assertion for the directory creation
## Root cause
`rmqctl/scripts/build-windows.ps1` invoked `go build -o bin\\rmqctl.exe` before creating the `bin` directory. A fresh checkout has no generated `bin` directory, so the default native build could not create its output file.
## Fix
Create the non-empty parent of the user-supplied `-Output` path before invoking `go build`. A filename-only output path remains supported.
## Testing
- `git diff --check`: passed
- `rmqctl/scripts/build_script_test.go`: updated to guard output-directory creation
- executable Go test/build: not run locally because Go is not installed in the environment
Fixes #7243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org