You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/05/17 19:51:12 UTC

[jira] [Commented] (FLINK-3914) BlobServer.createTemporaryFilename() has concurrency safety problem

    [ https://issues.apache.org/jira/browse/FLINK-3914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15287408#comment-15287408 ] 

ASF GitHub Bot commented on FLINK-3914:
---------------------------------------

GitHub user markreddy opened a pull request:

    https://github.com/apache/flink/pull/2000

    [FLINK-3914] [runtime] fixed race when attempting to create temp dir

    Flipped logic to prevent race on first few calls.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/markreddy/flink FLINK-3914-temp-file-concurrency

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2000.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2000
    
----
commit 0f9f919fb9ce9dbb23ab380eed3af4a8fecd2cc1
Author: Mark Reddy <ma...@gmail.com>
Date:   2016-05-17T19:38:36Z

    [FLINK-3914] [runtime] fixed race when attempting to create temp dir

----


> BlobServer.createTemporaryFilename() has concurrency safety problem
> -------------------------------------------------------------------
>
>                 Key: FLINK-3914
>                 URL: https://issues.apache.org/jira/browse/FLINK-3914
>             Project: Flink
>          Issue Type: Bug
>            Reporter: ZhengBowen
>            Assignee: Mark Reddy
>
> When JobManager just started to receive multiple concurrent requests,BlobServer.createTemporaryFilename() has concurrency safety problem.
> Exception:
> ```
> [2016-05-13 10:53:10.262] [BLOB connection for /xx.xx.xx.xx:55231] ERROR org.apache.flink.runtime.blob.BlobServerConnection - PUT operation failed
> java.lang.RuntimeException: Cannot create directory for incoming files D:\RDSWorkSpace\computing-rc\target\test\tmp\blobs\blobStore-63d1bef5-d92c-4a24-bf34-ff9c23046b71\incoming
> 	at org.apache.flink.runtime.blob.BlobUtils.getIncomingDirectory(BlobUtils.java:112) ~[flink-runtime-rds-1.0.0-SNAPSHOT.jar:1.0.0-SNAPSHOT]
> 	at org.apache.flink.runtime.blob.BlobServer.createTemporaryFilename(BlobServer.java:217) ~[flink-runtime-rds-1.0.0-SNAPSHOT.jar:1.0.0-SNAPSHOT]
> 	at org.apache.flink.runtime.blob.BlobServerConnection.put(BlobServerConnection.java:296) [flink-runtime-rds-1.0.0-SNAPSHOT.jar:1.0.0-SNAPSHOT]
> 	at org.apache.flink.runtime.blob.BlobServerConnection.run(BlobServerConnection.java:109) [flink-runtime-rds-1.0.0-SNAPSHOT.jar:1.0.0-SNAPSHOT]
> ```



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)