You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/03/04 19:45:19 UTC
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #23964:
[SPARK-26975][SQL] Support nested-column pruning over
limit/sample/repartition
dongjoon-hyun commented on a change in pull request #23964: [SPARK-26975][SQL] Support nested-column pruning over limit/sample/repartition
URL: https://github.com/apache/spark/pull/23964#discussion_r262214266
##########
File path: sql/core/benchmarks/NestedSchemaPruningBenchmark-results.txt
##########
@@ -4,37 +4,37 @@ Nested Schema Pruning Benchmark
Java HotSpot(TM) 64-Bit Server VM 1.8.0_201-b09 on Mac OS X 10.14.3
Intel(R) Core(TM) i9-8950HK CPU @ 2.90GHz
-Selection: Best/Avg Time(ms) Rate(M/s) Per Row(ns) Relative
-------------------------------------------------------------------------------------------------
-Top-level column 59 / 68 16.9 59.1 1.0X
-Nested column 180 / 186 5.6 179.7 0.3X
+Selection: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative
+------------------------------------------------------------------------------------------------------------------------
+Top-level column 62 71 9 16.2 61.6 1.0X
+Nested column 178 185 6 5.6 178.0 0.3X
Java HotSpot(TM) 64-Bit Server VM 1.8.0_201-b09 on Mac OS X 10.14.3
Intel(R) Core(TM) i9-8950HK CPU @ 2.90GHz
-Limiting: Best/Avg Time(ms) Rate(M/s) Per Row(ns) Relative
-------------------------------------------------------------------------------------------------
-Top-level column 241 / 246 4.2 240.9 1.0X
-Nested column 1828 / 1904 0.5 1827.5 0.1X
+Limiting: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative
+------------------------------------------------------------------------------------------------------------------------
+Top-level column 241 244 3 4.2 240.8 1.0X
+Nested column 358 371 8 2.8 358.2 0.7X
Review comment:
This and the next one is the scope of this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org