You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/10/11 09:13:04 UTC
[GitHub] [airflow] vksunilk opened a new pull request, #26986: Persist DataprocLink for workflow operators regardless of job status
vksunilk opened a new pull request, #26986:
URL: https://github.com/apache/airflow/pull/26986
For DataprocInstantiateInlineWorkflowTemplateOperator and DataprocInstantiateWorkflowTemplateOperator, the dataproc link is available only for the jobs that have succeeded. Incase of Failure, the DataprocLink is not available
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #26986: Persist DataprocLink for workflow operators regardless of job status
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #26986:
URL: https://github.com/apache/airflow/pull/26986
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #26986: Persist DataprocLink for workflow operators regardless of job status
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #26986:
URL: https://github.com/apache/airflow/pull/26986#issuecomment-1317691999
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] vksunilk commented on pull request #26986: Persist DataprocLink for workflow operators regardless of job status
Posted by GitBox <gi...@apache.org>.
vksunilk commented on PR #26986:
URL: https://github.com/apache/airflow/pull/26986#issuecomment-1313490284
> > Done now. Precommit helped!
>
> Let's see. You are a new user, so I still needed to approve the workflow run from you to run tests.
Finally, it has passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #26986: Persist DataprocLink for workflow operators regardless of job status
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26986:
URL: https://github.com/apache/airflow/pull/26986#issuecomment-1304836092
statuic checks failing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #26986: Persist DataprocLink for workflow operators regardless of job status
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #26986:
URL: https://github.com/apache/airflow/pull/26986#issuecomment-1274372664
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #26986: Persist DataprocLink for workflow operators regardless of job status
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26986:
URL: https://github.com/apache/airflow/pull/26986#issuecomment-1312083630
Nope :( .Static checks are failing. I recommend you to install pre-commit . It will correct the errors for you automatically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #26986: Persist DataprocLink for workflow operators regardless of job status
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26986:
URL: https://github.com/apache/airflow/pull/26986#issuecomment-1313439364
> Done now. Precommit helped!
Let's see. You are a new user, so I still needed to approve the workflow run from you to run tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #26986: Persist DataprocLink for workflow operators regardless of job status
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26986:
URL: https://github.com/apache/airflow/pull/26986#issuecomment-1313488999
Anyone from GCP team wants to comment @bjankie1 ? others ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] vksunilk commented on pull request #26986: Persist DataprocLink for workflow operators regardless of job status
Posted by GitBox <gi...@apache.org>.
vksunilk commented on PR #26986:
URL: https://github.com/apache/airflow/pull/26986#issuecomment-1305029310
> statuic checks failing.
It has passed now @potiuk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] vksunilk commented on pull request #26986: Persist DataprocLink for workflow operators regardless of job status
Posted by GitBox <gi...@apache.org>.
vksunilk commented on PR #26986:
URL: https://github.com/apache/airflow/pull/26986#issuecomment-1313163186
> Nope :( .Static checks are failing. I recommend you to install pre-commit . It will correct the errors for you automatically.
Done now. Precommit helped!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #26986: Persist DataprocLink for workflow operators regardless of job status
Posted by GitBox <gi...@apache.org>.
uranusjr commented on PR #26986:
URL: https://github.com/apache/airflow/pull/26986#issuecomment-1275959126
Would it be possible to add a test for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] vksunilk commented on pull request #26986: Persist DataprocLink for workflow operators regardless of job status
Posted by GitBox <gi...@apache.org>.
vksunilk commented on PR #26986:
URL: https://github.com/apache/airflow/pull/26986#issuecomment-1276244988
> Would it be possible to add a test for this?
@uranusjr Sure. Have added tests now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org