You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Elliott Clark (JIRA)" <ji...@apache.org> on 2012/11/19 19:13:59 UTC
[jira] [Created] (HBASE-7186) Split Classes for Client/Server
module split.
Elliott Clark created HBASE-7186:
------------------------------------
Summary: Split Classes for Client/Server module split.
Key: HBASE-7186
URL: https://issues.apache.org/jira/browse/HBASE-7186
Project: HBase
Issue Type: Sub-task
Reporter: Elliott Clark
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7186) Split Classes for Client/Server
module split.
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505717#comment-13505717 ]
Elliott Clark commented on HBASE-7186:
--------------------------------------
I'll need to rebase this once all of the changes due to the second round of protobufing goes in.
> Split Classes for Client/Server module split.
> ---------------------------------------------
>
> Key: HBASE-7186
> URL: https://issues.apache.org/jira/browse/HBASE-7186
> Project: HBase
> Issue Type: Sub-task
> Components: Client, Protobufs
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Fix For: 0.96.0
>
> Attachments: HBASE-7186-0.patch, HBASE-7186-1.patch
>
>
> Prepare classes for the coming hbase-client/hbase-server split.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7186) Split Classes for Client/Server
module split.
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13509556#comment-13509556 ]
stack commented on HBASE-7186:
------------------------------
BloomType probably belongs w/ other Bloom clases over under util (this is bad place for them too...so probably fine where you have it now under RegionServer... until Blooms get cleaned up).
Not you but maybe internal to setBloomType.... it would to the uppercasing rather than expect the caller passing upper case:
+ setBloomFilterType(BloomType.
valueOf(bloomFilter.toUpperCase()));
Don't know how you can get rid of setTableDesc and getTableDesc but I like it.
You starting a method cache in HBaseClient in methodInstances? Seems fine.
HBaseClientRPC is missing a license.
Did about 10%. Looks good so far.
> Split Classes for Client/Server module split.
> ---------------------------------------------
>
> Key: HBASE-7186
> URL: https://issues.apache.org/jira/browse/HBASE-7186
> Project: HBase
> Issue Type: Sub-task
> Components: Client, Protobufs
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Fix For: 0.96.0
>
> Attachments: HBASE-7186-0.patch, HBASE-7186-1.patch
>
>
> Prepare classes for the coming hbase-client/hbase-server split.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7186) Split Classes for Client/Server
module split.
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13509563#comment-13509563 ]
Elliott Clark commented on HBASE-7186:
--------------------------------------
bq.Don't know how you can get rid of setTableDesc and getTableDesc but I like it.
I checked and it's been deprecated since before 0.92 and nothing but tests were using it. So since it would pull all of the hdfs reading code I removed it.
bq.You starting a method cache in HBaseClient in methodInstances? Seems fine.
Yep there's a similar one in HBaseServer. So I just copied most of the implementation into the client.
bq.HBaseClientRPC is missing a license.
Yep. Missed that one.
> Split Classes for Client/Server module split.
> ---------------------------------------------
>
> Key: HBASE-7186
> URL: https://issues.apache.org/jira/browse/HBASE-7186
> Project: HBase
> Issue Type: Sub-task
> Components: Client, Protobufs
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Fix For: 0.96.0
>
> Attachments: HBASE-7186-0.patch, HBASE-7186-1.patch
>
>
> Prepare classes for the coming hbase-client/hbase-server split.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira