You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "miland-db (via GitHub)" <gi...@apache.org> on 2025/01/27 16:02:45 UTC
[PR] [SPARK-50663][SQL] Fix grammar for IF ELSE statement [spark]
miland-db opened a new pull request, #49694:
URL: https://github.com/apache/spark/pull/49694
### What changes were proposed in this pull request?
In this PR we are fixing grammar for `else if` block. Instead of current `ELSE IF` parser rule, new rule is `ELSEIF` according to SQL Standard and [Ref Spec](https://docs.google.com/document/d/1uFv2VoqDoOH2k6HfgdkBYxp-Ou7Qi721eexNW6IYWwk/edit?tab=t.0#heading=h.4cz970y1mk93)
### Why are the changes needed?
This changes are needed to follow grammar of the SQL Standard.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Updated tests containing `IF ELSE` statement and all other existing tests ensuring things are working as before.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50663][SQL] Fix grammar for IF ELSE statement (ELSE IF -> ELSEIF) [spark]
Posted by "miland-db (via GitHub)" <gi...@apache.org>.
miland-db commented on PR #49694:
URL: https://github.com/apache/spark/pull/49694#issuecomment-2618975014
Hi @MaxGekk, Please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50663][SQL] Fix grammar for IF ELSE statement (ELSE IF -> ELSEIF) [spark]
Posted by "miland-db (via GitHub)" <gi...@apache.org>.
miland-db commented on PR #49694:
URL: https://github.com/apache/spark/pull/49694#issuecomment-2621936303
@MaxGekk done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50663][SQL] Fix grammar for IF ELSE statement (ELSE IF -> ELSEIF) [spark]
Posted by "miland-db (via GitHub)" <gi...@apache.org>.
miland-db commented on PR #49694:
URL: https://github.com/apache/spark/pull/49694#issuecomment-2616390080
Adding @cloud-fan @MaxGekk @srielau
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50663][SQL] Fix grammar for IF ELSE statement (ELSE IF -> ELSEIF) [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #49694:
URL: https://github.com/apache/spark/pull/49694#issuecomment-2622187997
+1, LGTM. Merging to master/4.0.
Thank you, @miland-db and @srielau @dejankrak-db @beliefer @davidm-db @dusantism-db for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50663][SQL] Fix grammar for IF ELSE statement (ELSE IF -> ELSEIF) [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk closed pull request #49694: [SPARK-50663][SQL] Fix grammar for IF ELSE statement (ELSE IF -> ELSEIF)
URL: https://github.com/apache/spark/pull/49694
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org