You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/02/19 03:16:14 UTC
[GitHub] [incubator-doris] yangzhg opened a new pull request #2941: drop
index when index column is dropped
yangzhg opened a new pull request #2941: drop index when index column is dropped
URL: https://github.com/apache/incubator-doris/pull/2941
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] kangpinghuang commented on a change in pull
request #2941: drop index when index column is dropped
Posted by GitBox <gi...@apache.org>.
kangpinghuang commented on a change in pull request #2941: drop index when index column is dropped
URL: https://github.com/apache/incubator-doris/pull/2941#discussion_r381058566
##########
File path: fe/src/main/java/org/apache/doris/alter/SchemaChangeHandler.java
##########
@@ -157,7 +158,7 @@ private void processAddColumns(AddColumnsClause alterClause, OlapTable olapTable
}
private void processDropColumn(DropColumnClause alterClause, OlapTable olapTable,
- Map<Long, LinkedList<Column>> indexSchemaMap) throws DdlException {
+ Map<Long, LinkedList<Column>> indexSchemaMap, List<Index> indexes) throws DdlException {
Review comment:
add some comment for this argments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] kangpinghuang commented on a change in pull
request #2941: drop index when index column is dropped
Posted by GitBox <gi...@apache.org>.
kangpinghuang commented on a change in pull request #2941: drop index when index column is dropped
URL: https://github.com/apache/incubator-doris/pull/2941#discussion_r381058492
##########
File path: fe/src/main/java/org/apache/doris/alter/SchemaChangeHandler.java
##########
@@ -224,7 +225,17 @@ private void processDropColumn(DropColumnClause alterClause, OlapTable olapTable
}
}
}
-
+
+ Iterator<Index> it = indexes.iterator();
+ while(it.hasNext()){
+ Index index = it.next();
+ if(index.getIndexType() == IndexDef.IndexType.BITMAP
Review comment:
If the column is dropped, all type of index should be dropped, so here should not add this if clause.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #2941: drop index
when index column is dropped
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #2941: drop index when index column is dropped
URL: https://github.com/apache/incubator-doris/pull/2941
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org