You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/05 20:22:25 UTC

[GitHub] [airflow] jedcunningham commented on a change in pull request #14085: Ensure executors end method is called

jedcunningham commented on a change in pull request #14085:
URL: https://github.com/apache/airflow/pull/14085#discussion_r570601695



##########
File path: airflow/jobs/scheduler_job.py
##########
@@ -1292,13 +1292,12 @@ def _execute(self) -> None:
                 )
                 models.DAG.deactivate_stale_dags(execute_start_time)
 
-            self.executor.end()
-
             settings.Session.remove()  # type: ignore
         except Exception:  # pylint: disable=broad-except
             self.log.exception("Exception when executing SchedulerJob._run_scheduler_loop")
         finally:
             self.processor_agent.end()

Review comment:
       I think we can drop the `self.processor_agent.end()` in `_exit_gracefully` as it would be called here anyways. Thoughts?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org