You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yifan Zhang (Code Review)" <ge...@cloudera.org> on 2022/03/21 08:05:25 UTC

[kudu-CR] [www] Add pagination and search to /tables

Yifan Zhang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18334


Change subject: [www] Add pagination and search to /tables
......................................................................

[www] Add pagination and search to /tables

To make it convenient to search a table in a large cluster.

Change-Id: Ie4e958026df3734bda74ce78d3e1b929ea95fad1
---
M www/tables.mustache
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/34/18334/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18334
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie4e958026df3734bda74ce78d3e1b929ea95fad1
Gerrit-Change-Number: 18334
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>

[kudu-CR] [www] Add pagination and search to /tables

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18334 )

Change subject: [www] Add pagination and search to /tables
......................................................................


Patch Set 1: Code-Review+2

Thank you for the contribution!


-- 
To view, visit http://gerrit.cloudera.org:8080/18334
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4e958026df3734bda74ce78d3e1b929ea95fad1
Gerrit-Change-Number: 18334
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 21 Mar 2022 15:25:28 +0000
Gerrit-HasComments: No

[kudu-CR] [www] Add pagination and search to /tables

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: [www] Add pagination and search to /tables
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/18334
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ie4e958026df3734bda74ce78d3e1b929ea95fad1
Gerrit-Change-Number: 18334
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [www] Add pagination and search to /tables

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18334 )

Change subject: [www] Add pagination and search to /tables
......................................................................

[www] Add pagination and search to /tables

To make it convenient to search a table in a large cluster.

Change-Id: Ie4e958026df3734bda74ce78d3e1b929ea95fad1
Reviewed-on: http://gerrit.cloudera.org:8080/18334
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M www/tables.mustache
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Alexey Serbin: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/18334
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie4e958026df3734bda74ce78d3e1b929ea95fad1
Gerrit-Change-Number: 18334
Gerrit-PatchSet: 2
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [www] Add pagination and search to /tables

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18334 )

Change subject: [www] Add pagination and search to /tables
......................................................................


Patch Set 1: Verified+1

unrelated test failures in:
  * org.apache.kudu.spark.kudu.DefaultSourceTest
  * master-stress-test.1


-- 
To view, visit http://gerrit.cloudera.org:8080/18334
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4e958026df3734bda74ce78d3e1b929ea95fad1
Gerrit-Change-Number: 18334
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 21 Mar 2022 15:25:03 +0000
Gerrit-HasComments: No