You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Carl-Eric Menzel (JIRA)" <ji...@apache.org> on 2012/05/21 18:08:41 UTC

[jira] [Resolved] (WICKET-4537) Add Generics to TabbedPanel:

     [ https://issues.apache.org/jira/browse/WICKET-4537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carl-Eric Menzel resolved WICKET-4537.
--------------------------------------

    Resolution: Fixed

Pushed to master and wicket-1.5.x.

clirr didn't complain, so I'm assuming this is not breaking anything, at least not in binaries. It can easily be reverted in case of problems.
                
> Add Generics to TabbedPanel: <T extends ITab>
> ---------------------------------------------
>
>                 Key: WICKET-4537
>                 URL: https://issues.apache.org/jira/browse/WICKET-4537
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.5.6, 6.0.0-beta1
>            Reporter: Carl-Eric Menzel
>            Assignee: Carl-Eric Menzel
>             Fix For: 1.5.7, 6.0.0
>
>
> In 1.5, TabbedPanel#tabs has a wildcard signature: List<? extends ITab>. This makes it impossible to add tabs to that list, even though adding panels is one of the stated purposes of the #getTabs() method.
> On #wicket, dashorst suggested giving TabbedPanel a type parameter <T extends ITab>, which I think is a good idea. It should definitely be added in 6.0.
> What about 1.5.x? This would be a source-level break, but I *think* binaries should still work.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira