[jira] Commented: (HADOOP-3785) FileSystem cache should be case-insensitive

["Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-3785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12619597#action_12619597 ] 

Tsz Wo (Nicholas), SZE commented on HADOOP-3785:
------------------------------------------------

I think it would be more safe for keeping scheme and authority to null instead of setting them to empty strings.  Have you run all the unit tests?

> FileSystem cache should be case-insensitive
> -------------------------------------------
>
>                 Key: HADOOP-3785
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3785
>             Project: Hadoop Core
>          Issue Type: Bug
>            Reporter: Doug Cutting
>            Assignee: Bill de hOra
>             Fix For: 0.19.0
>
>         Attachments: HADOOP-3785.patch
>
>
> We cache FileSystem instances based on URI scheme & authority, plus username.  Elsewhere we compare URI schemes and authorities case-insensitively, but the cache is case-sensitive.  In particular, the Cache.Key#equals() and Cache.Key#hashCode() should be made case-insensitive.
> This should not be a blocker, since the worst it causes is a few extra FileSystem instances to be cached.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.