You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Sean Hsuan-Yi Chu <hs...@usc.edu> on 2015/06/25 01:14:26 UTC
Review Request 35851: DRILL-3359: Drill should throw and error when
window function defined using WINDOW AS
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35851/
-----------------------------------------------------------
Review request for drill and Aman Sinha.
Bugs: DRILL-3359
https://issues.apache.org/jira/browse/DRILL-3359
Repository: drill-git
Description
-------
Also detect the window frame claimed in the window definition
Diffs
-----
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillPreparedStatement.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillPreparedStatementImpl.java 5e9ec93
exec/jdbc/src/test/java/org/apache/drill/jdbc/PreparedStatementTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/35851/diff/
Testing
-------
unit test is done;
others are in the line
Thanks,
Sean Hsuan-Yi Chu
Re: Review Request 35851: DRILL-3359: Drill should throw and error
when window function defined using WINDOW AS
Posted by Aman Sinha <as...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35851/#review89286
-----------------------------------------------------------
I don't see anything related to window functions...is this the right patch ?
- Aman Sinha
On June 24, 2015, 11:14 p.m., Sean Hsuan-Yi Chu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35851/
> -----------------------------------------------------------
>
> (Updated June 24, 2015, 11:14 p.m.)
>
>
> Review request for drill and Aman Sinha.
>
>
> Bugs: DRILL-3359
> https://issues.apache.org/jira/browse/DRILL-3359
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Also detect the window frame claimed in the window definition
>
>
> Diffs
> -----
>
> exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillPreparedStatement.java PRE-CREATION
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillPreparedStatementImpl.java 5e9ec93
> exec/jdbc/src/test/java/org/apache/drill/jdbc/PreparedStatementTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/35851/diff/
>
>
> Testing
> -------
>
> unit test is done;
> others are in the line
>
>
> Thanks,
>
> Sean Hsuan-Yi Chu
>
>
Re: Review Request 35851: DRILL-3359: Drill should throw and error
when window function defined using WINDOW AS
Posted by Aman Sinha <as...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35851/#review89312
-----------------------------------------------------------
Ship it!
Ship It!
- Aman Sinha
On June 24, 2015, 11:49 p.m., Sean Hsuan-Yi Chu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35851/
> -----------------------------------------------------------
>
> (Updated June 24, 2015, 11:49 p.m.)
>
>
> Review request for drill and Aman Sinha.
>
>
> Bugs: DRILL-3359
> https://issues.apache.org/jira/browse/DRILL-3359
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Also detect the window frame claimed in the window definition
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java 0c5afc1
> exec/java-exec/src/test/java/org/apache/drill/exec/TestWindowFunctions.java e8daff2
>
> Diff: https://reviews.apache.org/r/35851/diff/
>
>
> Testing
> -------
>
> unit test is done;
> others are in the line
>
>
> Thanks,
>
> Sean Hsuan-Yi Chu
>
>
Re: Review Request 35851: DRILL-3359: Drill should throw and error
when window function defined using WINDOW AS
Posted by Sean Hsuan-Yi Chu <hs...@usc.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35851/
-----------------------------------------------------------
(Updated June 24, 2015, 11:49 p.m.)
Review request for drill and Aman Sinha.
Changes
-------
the right patch; Sorry too many things on my desktop
Bugs: DRILL-3359
https://issues.apache.org/jira/browse/DRILL-3359
Repository: drill-git
Description
-------
Also detect the window frame claimed in the window definition
Diffs (updated)
-----
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java 0c5afc1
exec/java-exec/src/test/java/org/apache/drill/exec/TestWindowFunctions.java e8daff2
Diff: https://reviews.apache.org/r/35851/diff/
Testing
-------
unit test is done;
others are in the line
Thanks,
Sean Hsuan-Yi Chu