You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@streampark.apache.org by "wolfboys (via GitHub)" <gi...@apache.org> on 2023/04/12 06:39:08 UTC
[GitHub] [incubator-streampark] wolfboys opened a new pull request, #2602: [Improve] Flink CONF_DIR improvement
wolfboys opened a new pull request, #2602:
URL: https://github.com/apache/incubator-streampark/pull/2602
[Improve] Flink CONF_DIR improvement
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] zhoulii commented on pull request #2602: [Improve] Flink CONF_DIR improvement
Posted by "zhoulii (via GitHub)" <gi...@apache.org>.
zhoulii commented on PR #2602:
URL: https://github.com/apache/incubator-streampark/pull/2602#issuecomment-1506184104
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] zhoulii commented on a diff in pull request #2602: [Improve] Flink CONF_DIR improvement
Posted by "zhoulii (via GitHub)" <gi...@apache.org>.
zhoulii commented on code in PR #2602:
URL: https://github.com/apache/incubator-streampark/pull/2602#discussion_r1163900581
##########
streampark-flink/streampark-flink-client/streampark-flink-client-core/src/main/scala/org/apache/streampark/flink/client/trait/KubernetesNativeClientTrait.scala:
##########
@@ -49,16 +48,9 @@ trait KubernetesNativeClientTrait extends FlinkClientTrait {
KubernetesConfigOptions.REST_SERVICE_EXPOSED_TYPE,
covertToServiceExposedType(submitRequest.k8sSubmitParam.flinkRestExposedType))
- if (submitRequest.buildResult != null) {
- if (submitRequest.executionMode == ExecutionMode.KUBERNETES_NATIVE_APPLICATION) {
- val buildResult = submitRequest.buildResult.asInstanceOf[DockerImageBuildResponse]
- buildResult.podTemplatePaths.foreach(p => {
- flinkConfig
- .safeSet(KubernetesConfigOptions.KUBERNETES_POD_TEMPLATE, p._2)
- .safeSet(KubernetesConfigOptions.JOB_MANAGER_POD_TEMPLATE, p._2)
- .safeSet(KubernetesConfigOptions.TASK_MANAGER_POD_TEMPLATE, p._2)
- })
- }
+ // add flink conf configuration, mainly to set the log4j configuration
+ if (!flinkConfig.contains(DeploymentOptionsInternal.CONF_DIR)) {
+ flinkConfig.safeSet(DeploymentOptionsInternal.CONF_DIR, s"${submitRequest.flinkVersion.flinkHome}/conf")
}
Review Comment:
From what I understand，KubernetesNativeApplicationClient overwrite the setConfig method, this step won't take effect for k8s application mode submit, maybe we can invoke this method in KubernetesNativeApplicationClient#setConfig ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] wolfboys closed pull request #2602: [Improve] Flink CONF_DIR improvement
Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys closed pull request #2602: [Improve] Flink CONF_DIR improvement
URL: https://github.com/apache/incubator-streampark/pull/2602
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] wolfboys commented on pull request #2602: [Improve] Flink CONF_DIR improvement
Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys commented on PR #2602:
URL: https://github.com/apache/incubator-streampark/pull/2602#issuecomment-1505513543
cc @zhoulii PTAL. thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] wolfboys commented on a diff in pull request #2602: [Improve] Flink CONF_DIR improvement
Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys commented on code in PR #2602:
URL: https://github.com/apache/incubator-streampark/pull/2602#discussion_r1164316768
##########
streampark-flink/streampark-flink-client/streampark-flink-client-core/src/main/scala/org/apache/streampark/flink/client/trait/KubernetesNativeClientTrait.scala:
##########
@@ -49,16 +48,9 @@ trait KubernetesNativeClientTrait extends FlinkClientTrait {
KubernetesConfigOptions.REST_SERVICE_EXPOSED_TYPE,
covertToServiceExposedType(submitRequest.k8sSubmitParam.flinkRestExposedType))
- if (submitRequest.buildResult != null) {
- if (submitRequest.executionMode == ExecutionMode.KUBERNETES_NATIVE_APPLICATION) {
- val buildResult = submitRequest.buildResult.asInstanceOf[DockerImageBuildResponse]
- buildResult.podTemplatePaths.foreach(p => {
- flinkConfig
- .safeSet(KubernetesConfigOptions.KUBERNETES_POD_TEMPLATE, p._2)
- .safeSet(KubernetesConfigOptions.JOB_MANAGER_POD_TEMPLATE, p._2)
- .safeSet(KubernetesConfigOptions.TASK_MANAGER_POD_TEMPLATE, p._2)
- })
- }
+ // add flink conf configuration, mainly to set the log4j configuration
+ if (!flinkConfig.contains(DeploymentOptionsInternal.CONF_DIR)) {
+ flinkConfig.safeSet(DeploymentOptionsInternal.CONF_DIR, s"${submitRequest.flinkVersion.flinkHome}/conf")
}
Review Comment:
> From what I understand，KubernetesNativeApplicationClient overwrite the setConfig method, this step won't take effect for k8s application mode submit, maybe we can invoke this method in KubernetesNativeApplicationClient#setConfig ?
Thanks for your review, updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org