[GitHub] [thrift] ctubbsii commented on a diff in pull request #2600: THRIFT-5580: refactor kotlin cross test to use proper cli framework, add more transport/protocol cases

[GitBox <gi...@apache.org>]

ctubbsii commented on code in PR #2600:
URL: https://github.com/apache/thrift/pull/2600#discussion_r867438168


##########
lib/kotlin/cross-test-client/build.gradle.kts:
##########
@@ -33,10 +33,14 @@ val httpclientVersion: String by project
 val httpcoreVersion: String by project
 val logbackVersion: String by project
 val kotlinxCoroutinesJdk8Version: String by project
+val cliktVersion: String by project
 
 dependencies {
     implementation(platform("org.jetbrains.kotlin:kotlin-bom"))
     implementation("org.jetbrains.kotlin:kotlin-stdlib-jdk8")
+    // clikt is used to drive command line parsing and validation
+    // https://mvnrepository.com/artifact/com.github.ajalt.clikt/clikt

Review Comment:
   I only just noticed these links. Please remove links to mvnrepository.com. It's a third-party indexing service, not affiliated with Maven Central, where these artifacts are being published. The maven coordinates are sufficient for people to find the artifact at search.maven.org, the official indexing service of Maven Central, or from their local maven repository acting as a proxy for Maven Central or hosting their local builds.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org