You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/08/12 19:03:49 UTC

[GitHub] [hudi] vinishjail97 commented on a diff in pull request #6387: [HUDI-4615] Return checkpoint as null for empty data from events queue.

vinishjail97 commented on code in PR #6387:
URL: https://github.com/apache/hudi/pull/6387#discussion_r944762874


##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/helpers/S3EventsMetaSelector.java:
##########
@@ -153,6 +153,8 @@ public Pair<List<String>, String> getNextEventsFromQueue(AmazonSQS sqs,
       for (Map<String, Object> eventRecord : eventRecords) {
         filteredEventRecords.add(new ObjectMapper().writeValueAsString(eventRecord).replace("%3D", "="));
       }
+      // Return the old checkpoint if no messages to consume from queue.
+      String newCheckpoint = newCheckpointTime == 0 ? lastCheckpointStr.orElse(null) : String.valueOf(newCheckpointTime);

Review Comment:
   Updated. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org