You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by "Aditya Kishore (JIRA)" <ji...@apache.org> on 2012/10/13 12:29:02 UTC

[jira] [Created] (HBASE-6991) Bytes.toStringBinary() and its counterpart Bytes.toBytesBinary() are not always consistant

Aditya Kishore created HBASE-6991:
-------------------------------------

             Summary: Bytes.toStringBinary() and its counterpart Bytes.toBytesBinary() are not always consistant
                 Key: HBASE-6991
                 URL: https://issues.apache.org/jira/browse/HBASE-6991
             Project: HBase
          Issue Type: Bug
          Components: util
    Affects Versions: 0.96.0
            Reporter: Aditya Kishore
            Assignee: Aditya Kishore


Since "\" is used to escape non-printable character but not treated as special character in conversion, it could lead to unexpected conversion.

For example, please consider the following code snippet.

{code}
public void testConversion() {
  byte[] original = {
      '\\', 'x', 'A', 'D'
  };
  String stringFromBytes = Bytes.toStringBinary(original);
  byte[] converted = Bytes.toBytesBinary(stringFromBytes);
  System.out.println("Original: " + Arrays.toString(original));
  System.out.println("Converted: " + Arrays.toString(converted));
  System.out.println("Reversible?: " + (Bytes.compareTo(original, converted) == 0));
}

Output:
-------
Original: [92, 120, 65, 68]
Converted: [-83]
Reversible?: false
{code}

The "\" character needs to be treated as special and must be encoded as a non-printable character ("\x5C") to avoid any kind of unambiguity during conversion.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-6991) Escape "\" in Bytes.toStringBinary() and its counterpart Bytes.toBytesBinary()

Posted by "stack (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/HBASE-6991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-6991:
-------------------------

      Resolution: Fixed
    Hadoop Flags: Incompatible change,Reviewed  (was: Incompatible change)
          Status: Resolved  (was: Patch Available)

Committed to trunk.  Thanks for the patch Aditya.  Nice one.  That already encoded stuff should be undone properly should protect us against pre 0.96 data looking different in 0.96.
                
> Escape "\" in Bytes.toStringBinary() and its counterpart Bytes.toBytesBinary()
> ------------------------------------------------------------------------------
>
>                 Key: HBASE-6991
>                 URL: https://issues.apache.org/jira/browse/HBASE-6991
>             Project: HBase
>          Issue Type: Bug
>          Components: util
>    Affects Versions: 0.96.0
>            Reporter: Aditya Kishore
>            Assignee: Aditya Kishore
>             Fix For: 0.96.0
>
>         Attachments: HBASE-6991_trunk.patch
>
>
> Since "\" is used to escape non-printable character but not treated as special character in conversion, it could lead to unexpected conversion.
> For example, please consider the following code snippet.
> {code}
> public void testConversion() {
>   byte[] original = {
>       '\\', 'x', 'A', 'D'
>   };
>   String stringFromBytes = Bytes.toStringBinary(original);
>   byte[] converted = Bytes.toBytesBinary(stringFromBytes);
>   System.out.println("Original: " + Arrays.toString(original));
>   System.out.println("Converted: " + Arrays.toString(converted));
>   System.out.println("Reversible?: " + (Bytes.compareTo(original, converted) == 0));
> }
> Output:
> -------
> Original: [92, 120, 65, 68]
> Converted: [-83]
> Reversible?: false
> {code}
> The "\" character needs to be treated as special and must be encoded as a non-printable character ("\x5C") to avoid any kind of ambiguity during conversion.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira