You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/10/27 11:45:19 UTC
[GitHub] [superset] geido opened a new issue #17243: [Dashboard] Color scheme won't be discarded when discarding changes
geido opened a new issue #17243:
URL: https://github.com/apache/superset/issues/17243
A clear and concise description of what the bug is.
#### How to reproduce the bug
1. Go to a Dashboard
2. Click on Edit dashboard properties
3. Change the color scheme and click Save
4. Without saving the whole dashboard, click on "Discard changes"
5. The page will refresh and the color scheme change hasn't been discarded
### Expected results
Saving changes in the "Edit dashboard properties" Modal should only be effective when the whole Dashboard is saved. When discarding the changes, any change should reset.
### Actual results
The color scheme is not discarded
#### Screenshots
https://user-images.githubusercontent.com/60598000/139059213-79862427-72a5-466d-b4e0-82ae74f00efc.mp4
### Environment
- browser type and version: Chrome
- superset version: `master`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jinghua-qa commented on issue #17243: [Dashboard] Color scheme won't be discarded when discarding changes
Posted by GitBox <gi...@apache.org>.
jinghua-qa commented on issue #17243:
URL: https://github.com/apache/superset/issues/17243#issuecomment-966460992
I have a question when I set a color theme in the chart and add it to a dashboard, why I can not see the color theme information in the dashboard edit mode?
https://user-images.githubusercontent.com/81597121/141337464-fe174a4b-8d9f-4abd-b371-62dfd7cf065e.mov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido closed issue #17243: [Dashboard] Color scheme won't be discarded when discarding changes
Posted by GitBox <gi...@apache.org>.
geido closed issue #17243:
URL: https://github.com/apache/superset/issues/17243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jinghua-qa removed a comment on issue #17243: [Dashboard] Color scheme won't be discarded when discarding changes
Posted by GitBox <gi...@apache.org>.
jinghua-qa removed a comment on issue #17243:
URL: https://github.com/apache/superset/issues/17243#issuecomment-966460992
I have a question when I set a color theme in the chart and add it to a dashboard, why I can not see the color theme information in the dashboard edit mode?
https://user-images.githubusercontent.com/81597121/141337464-fe174a4b-8d9f-4abd-b371-62dfd7cf065e.mov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on issue #17243: [Dashboard] Color scheme won't be discarded when discarding changes
Posted by GitBox <gi...@apache.org>.
geido commented on issue #17243:
URL: https://github.com/apache/superset/issues/17243#issuecomment-952838818
@junlincc @jinghua-qa FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org