[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #4766: [TE] Extending Jira Merge capabilities for supporting dimensional alerter

[GitBox <gi...@apache.org>]

jihaozh commented on a change in pull request #4766: [TE] Extending Jira Merge capabilities for supporting dimensional alerter
URL: https://github.com/apache/incubator-pinot/pull/4766#discussion_r341413678
 
 

 ##########
 File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/alert/DetectionAlertFilterNotification.java
 ##########
 @@ -27,19 +28,33 @@
  * Container class for notification properties
  */
 public class DetectionAlertFilterNotification {
+
   Map<String, Object> notificationSchemeProps;
+  Map<String, String> dimensionFilters;
 
   public DetectionAlertFilterNotification(Map<String, Object> notificationSchemeProps) {
+    this(notificationSchemeProps, new HashMap<>());
+  }
+
+  public DetectionAlertFilterNotification(Map<String, Object> notificationSchemeProps, Map<String, String> dimensionFilters) {
     this.notificationSchemeProps = notificationSchemeProps;
+    this.dimensionFilters = dimensionFilters;
   }
 
   public Map<String, Object> getNotificationSchemeProps() {
     return notificationSchemeProps;
   }
 
-  public DetectionAlertFilterNotification setNotificationSchemeProps(Map<String, Object> notificationSchemeProps) {
+  public void setNotificationSchemeProps(Map<String, Object> notificationSchemeProps) {
     this.notificationSchemeProps = notificationSchemeProps;
-    return this;
+  }
+
+  public Map<String, String> getDimensionFilters() {
 
 Review comment:
   Is this `dimensionFilters`  the same with the `DimensionMap` in the anomaly? shall we use MultiMap instead of Map?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org