[GitHub] [spark] cloud-fan commented on a change in pull request #26176: [SPARK-29519][SQL] SHOW TBLPROPERTIES should do multi-catalog resolution.

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #26176: [SPARK-29519][SQL] SHOW TBLPROPERTIES should do multi-catalog resolution.
URL: https://github.com/apache/spark/pull/26176#discussion_r336828491
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala
 ##########
 @@ -1210,6 +1210,23 @@ class DataSourceV2SQLSuite
     }
   }
 
+  test("SHOW TBLPROPERTIES") {
+    val t = "testcat.ns1.ns2.tbl"
+    withTable(t) {
+      spark.sql(s"CREATE TABLE $t (id bigint, data string) USING foo")
+
+      val e1 = intercept[AnalysisException] {
+        sql(s"SHOW TBLPROPERTIES $t")
+      }
+      assert(e1.message.contains("SHOW TBLPROPERTIES is only supported with v1 tables"))
 
 Review comment:
   I think we can implement SHOW TBLPROPERTIES with v2 APIs. You can refer to https://github.com/apache/spark/pull/26166 about how to implement a v2 command.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org