You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/01/26 14:35:24 UTC

[jira] [Commented] (KAFKA-4645) Improve test coverage of ProcessorTopology

    [ https://issues.apache.org/jira/browse/KAFKA-4645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15839756#comment-15839756 ] 

ASF GitHub Bot commented on KAFKA-4645:
---------------------------------------

GitHub user dguy opened a pull request:

    https://github.com/apache/kafka/pull/2444

    KAFKA-4645: Improve test coverage of ProcessorTopology

    the toString method prints the topology, but had no tests making sure it works and/or doesn't cause exceptions

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dguy/kafka KAFKA-4645

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/2444.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2444
    
----
commit 0a464a36761ea124a9621acb1c9231bafcbf4f76
Author: Damian Guy <da...@gmail.com>
Date:   2017-01-26T14:32:12Z

    improve test coverage

----


> Improve test coverage of ProcessorTopology
> ------------------------------------------
>
>                 Key: KAFKA-4645
>                 URL: https://issues.apache.org/jira/browse/KAFKA-4645
>             Project: Kafka
>          Issue Type: Sub-task
>          Components: streams
>    Affects Versions: 0.10.3.0
>            Reporter: Damian Guy
>            Assignee: Damian Guy
>            Priority: Minor
>             Fix For: 0.10.3.0
>
>
> The {{toString}} and {{childrenToString}} methods have no coverage. These are used for printing the topology, so there should be some unit tests



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)