You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/05/05 15:14:55 UTC

[GitHub] [mynewt-core] mlaz opened a new pull request #2280: adc/nrf52_adc: Driver improvements and fixes: calibration and gain

mlaz opened a new pull request #2280:
URL: https://github.com/apache/mynewt-core/pull/2280


   This PR addresses an issue with setting up the channel gain and makes the ADC calibrate(if calibrate is active) on every sample right after a configuration. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [mynewt-core] mlaz commented on pull request #2280: adc/nrf52_adc: Driver improvements and fixes: calibration and gain

Posted by GitBox <gi...@apache.org>.
mlaz commented on pull request #2280:
URL: https://github.com/apache/mynewt-core/pull/2280#issuecomment-624116627


   @gonccalo the problem you mentioned is fixed, please test. :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2280: adc/nrf52_adc: Driver improvements and fixes: calibration and gain

Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #2280:
URL: https://github.com/apache/mynewt-core/pull/2280#issuecomment-624117254


   
   <!-- style-bot -->
   
   ## Style check summary
   
   #### No suggestions at this time!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [mynewt-core] gonccalo commented on pull request #2280: adc/nrf52_adc: Driver improvements and fixes: calibration and gain

Posted by GitBox <gi...@apache.org>.
gonccalo commented on pull request #2280:
URL: https://github.com/apache/mynewt-core/pull/2280#issuecomment-624880800


   It's working, thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org