[GitHub] [spark] cloud-fan commented on a change in pull request #28048: [SPARK-31142][PYSPARK]Remove useless conf set in pyspark context

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #28048: [SPARK-31142][PYSPARK]Remove useless conf set in pyspark context
URL: https://github.com/apache/spark/pull/28048#discussion_r399934757
 
 

 ##########
 File path: python/pyspark/context.py
 ##########
 @@ -181,11 +181,6 @@ def _do_init(self, master, appName, sparkHome, pyFiles, environment, batchSize,
         self.appName = self._conf.get("spark.app.name")
         self.sparkHome = self._conf.get("spark.home", None)
 
-        for (k, v) in self._conf.getAll():
 
 Review comment:
   It will be great to add a test to demonstrate this problem.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org