You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jeff Sposetti <je...@hortonworks.com> on 2014/06/09 17:18:16 UTC
Review Request 22380: Add refreshQueues custom command to YARN service
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22380/
-----------------------------------------------------------
Review request for Ambari, Mahadev Konar and Nate Cole.
Bugs: AMBARI-6059
https://issues.apache.org/jira/browse/AMBARI-6059
Repository: ambari
Description
-------
Add a custom command to call refreshQueues on the ResourceManager.
Diffs
-----
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/metainfo.xml bb588a2
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/resourcemanager.py 84f0c84
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/service.py d854565
Diff: https://reviews.apache.org/r/22380/diff/
Testing
-------
Thanks,
Jeff Sposetti
Re: Review Request 22380: Add refreshQueues custom command to YARN service
Posted by Mahadev Konar <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22380/#review45083
-----------------------------------------------------------
Ship it!
Ship It!
- Mahadev Konar
On June 9, 2014, 3:18 p.m., Jeff Sposetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22380/
> -----------------------------------------------------------
>
> (Updated June 9, 2014, 3:18 p.m.)
>
>
> Review request for Ambari, Mahadev Konar and Nate Cole.
>
>
> Bugs: AMBARI-6059
> https://issues.apache.org/jira/browse/AMBARI-6059
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add a custom command to call refreshQueues on the ResourceManager.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/metainfo.xml bb588a2
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/resourcemanager.py 84f0c84
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/service.py d854565
>
> Diff: https://reviews.apache.org/r/22380/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jeff Sposetti
>
>
Re: Review Request 22380: Add refreshQueues custom command to YARN service
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22380/#review45080
-----------------------------------------------------------
Patch looks good, but requires some unit tests.
- Nate Cole
On June 9, 2014, 11:18 a.m., Jeff Sposetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22380/
> -----------------------------------------------------------
>
> (Updated June 9, 2014, 11:18 a.m.)
>
>
> Review request for Ambari, Mahadev Konar and Nate Cole.
>
>
> Bugs: AMBARI-6059
> https://issues.apache.org/jira/browse/AMBARI-6059
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add a custom command to call refreshQueues on the ResourceManager.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/metainfo.xml bb588a2
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/resourcemanager.py 84f0c84
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/service.py d854565
>
> Diff: https://reviews.apache.org/r/22380/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jeff Sposetti
>
>
Re: Review Request 22380: Add refreshQueues custom command to YARN service
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22380/#review45081
-----------------------------------------------------------
Ship it!
Just saw additional conversation regarding this patch.
- Nate Cole
On June 9, 2014, 11:18 a.m., Jeff Sposetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22380/
> -----------------------------------------------------------
>
> (Updated June 9, 2014, 11:18 a.m.)
>
>
> Review request for Ambari, Mahadev Konar and Nate Cole.
>
>
> Bugs: AMBARI-6059
> https://issues.apache.org/jira/browse/AMBARI-6059
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add a custom command to call refreshQueues on the ResourceManager.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/metainfo.xml bb588a2
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/resourcemanager.py 84f0c84
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/service.py d854565
>
> Diff: https://reviews.apache.org/r/22380/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jeff Sposetti
>
>
Re: Review Request 22380: Add refreshQueues custom command to YARN service
Posted by Mahadev Konar <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22380/#review45084
-----------------------------------------------------------
refresh_cmd = format("yarn rmadmin -refreshQueues") can you change this to {yarn_bin}/yarn rmadmin -refreshQueues
- Mahadev Konar
On June 9, 2014, 3:18 p.m., Jeff Sposetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22380/
> -----------------------------------------------------------
>
> (Updated June 9, 2014, 3:18 p.m.)
>
>
> Review request for Ambari, Mahadev Konar and Nate Cole.
>
>
> Bugs: AMBARI-6059
> https://issues.apache.org/jira/browse/AMBARI-6059
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add a custom command to call refreshQueues on the ResourceManager.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/metainfo.xml bb588a2
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/resourcemanager.py 84f0c84
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/service.py d854565
>
> Diff: https://reviews.apache.org/r/22380/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jeff Sposetti
>
>
Re: Review Request 22380: Add refreshQueues custom command to YARN service
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22380/#review45085
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On June 9, 2014, 12:05 p.m., Jeff Sposetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22380/
> -----------------------------------------------------------
>
> (Updated June 9, 2014, 12:05 p.m.)
>
>
> Review request for Ambari, Mahadev Konar and Nate Cole.
>
>
> Bugs: AMBARI-6059
> https://issues.apache.org/jira/browse/AMBARI-6059
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add a custom command to call refreshQueues on the ResourceManager.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/metainfo.xml bb588a2
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/resourcemanager.py 84f0c84
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/service.py d854565
>
> Diff: https://reviews.apache.org/r/22380/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jeff Sposetti
>
>
Re: Review Request 22380: Add refreshQueues custom command to YARN service
Posted by Jeff Sposetti <je...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22380/
-----------------------------------------------------------
(Updated June 9, 2014, 4:05 p.m.)
Review request for Ambari, Mahadev Konar and Nate Cole.
Changes
-------
Thanks. Updated patch.
Bugs: AMBARI-6059
https://issues.apache.org/jira/browse/AMBARI-6059
Repository: ambari
Description
-------
Add a custom command to call refreshQueues on the ResourceManager.
Diffs (updated)
-----
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/metainfo.xml bb588a2
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/resourcemanager.py 84f0c84
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/service.py d854565
Diff: https://reviews.apache.org/r/22380/diff/
Testing
-------
Thanks,
Jeff Sposetti