You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by xh...@apache.org on 2019/06/05 22:35:22 UTC

[incubator-pinot] branch master updated: update currentAnomalies to read new selectedRule object (#4282)

This is an automated email from the ASF dual-hosted git repository.

xhsun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git


The following commit(s) were added to refs/heads/master by this push:
     new 752196c  update currentAnomalies to read new selectedRule object (#4282)
752196c is described below

commit 752196c659991792ae544dad4e7a356a74a697a1
Author: Harley Jackson <hj...@linkedin.com>
AuthorDate: Wed Jun 5 15:35:16 2019 -0700

    update currentAnomalies to read new selectedRule object (#4282)
---
 .../thirdeye-frontend/app/pods/components/alert-details/component.js  | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/thirdeye/thirdeye-frontend/app/pods/components/alert-details/component.js b/thirdeye/thirdeye-frontend/app/pods/components/alert-details/component.js
index 1530ca5..feb19a3 100644
--- a/thirdeye/thirdeye-frontend/app/pods/components/alert-details/component.js
+++ b/thirdeye/thirdeye-frontend/app/pods/components/alert-details/component.js
@@ -367,8 +367,8 @@ export default Component.extend({
 
         currentAnomalies = anomalies.filter(anomaly => {
           if (anomaly.metricUrn === metricUrn) {
-            if(get(this, 'isPreviewMode') && anomaly.properties && typeof anomaly.properties === 'object') {
-              return (anomaly.properties.detectorComponentName.includes(selectedRule));
+            if(get(this, 'isPreviewMode') && anomaly.properties && typeof anomaly.properties === 'object' && selectedRule && typeof selectedRule === 'object') {
+              return (anomaly.properties.detectorComponentName.includes(selectedRule.detectorName));
             } else if (!get(this, 'isPreviewMode')) {
               // This is necessary until we surface rule selector in Alert Overview
               return true;


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org