You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2021/05/18 08:22:43 UTC

[GitHub] [servicecomb-java-chassis] kaister3 opened a new pull request #2387: [SCB-2267]add registryName api

kaister3 opened a new pull request #2387:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2387


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] codecov-commenter commented on pull request #2387: [SCB-2267]add registryName api

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #2387:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2387#issuecomment-843014401


   # [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2387?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2387](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2387?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (59fdaee) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/0eac3b2f9d8ca95d7429cb589e1ea1e4ba27fe9d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0eac3b2) will **decrease** coverage by `0.00%`.
   > The diff coverage is `20.00%`.
   
   > :exclamation: Current head 59fdaee differs from pull request most recent head a923707. Consider uploading reports for the commit a923707 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2387/graphs/tree.svg?width=650&height=150&src=pr&token=KXfDcr9rX2&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2387?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2387      +/-   ##
   ============================================
   - Coverage     80.30%   80.29%   -0.01%     
     Complexity     1382     1382              
   ============================================
     Files          1560     1560              
     Lines         41569    41574       +5     
     Branches       3488     3489       +1     
   ============================================
   + Hits          33381    33382       +1     
   - Misses         6680     6684       +4     
     Partials       1508     1508              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2387?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...che/servicecomb/serviceregistry/RegistryUtils.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2387/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L1JlZ2lzdHJ5VXRpbHMuamF2YQ==) | `80.30% <0.00%> (-1.24%)` | `0.00 <0.00> (ø)` | |
   | [...gistry/config/ServiceRegistryConfigCustomizer.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2387/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2NvbmZpZy9TZXJ2aWNlUmVnaXN0cnlDb25maWdDdXN0b21pemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...enterClient/ServerBServiceCenterConfiguration.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2387/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGVtby9kZW1vLW11bHRpLXNlcnZpY2UtY2VudGVyL2RlbW8tbXVsdGktc2VydmljZS1jZW50ZXItY2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9kZW1vL211bHRpU2VydmljZUNlbnRlckNsaWVudC9TZXJ2ZXJCU2VydmljZUNlbnRlckNvbmZpZ3VyYXRpb24uamF2YQ==) | `100.00% <100.00%> (ø)` | `2.00 <0.00> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2387?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2387?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0eac3b2...a923707](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2387?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] kaister3 commented on a change in pull request #2387: [SCB-2267]add registryName api

Posted by GitBox <gi...@apache.org>.
kaister3 commented on a change in pull request #2387:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2387#discussion_r634865284



##########
File path: service-registry/registry-service-center/src/main/java/org/apache/servicecomb/serviceregistry/RegistryUtils.java
##########
@@ -253,6 +253,9 @@ public static void executeOnEachServiceRegistry(Consumer<ServiceRegistry> action
 
   public static void addExtraServiceRegistry(ServiceRegistry serviceRegistry) {
     Objects.requireNonNull(serviceRegistry);
+    if (EXTRA_SERVICE_REGISTRIES.containsKey(serviceRegistry.getName())) {
+      throw new IllegalArgumentException("Register name duplicated!");

Review comment:
       when duplicated, I can only get the new client name, cannot get old client name from EXTRA_SERVICE_REGISTRY. How to set different implementation?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] liubao68 merged pull request #2387: [SCB-2267]add registryName api

Posted by GitBox <gi...@apache.org>.
liubao68 merged pull request #2387:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2387


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] codecov-commenter edited a comment on pull request #2387: [SCB-2267]add registryName api

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2387:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2387#issuecomment-843014401


   # [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2387?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2387](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2387?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (572d767) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/0eac3b2f9d8ca95d7429cb589e1ea1e4ba27fe9d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0eac3b2) will **decrease** coverage by `0.02%`.
   > The diff coverage is `12.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2387/graphs/tree.svg?width=650&height=150&src=pr&token=KXfDcr9rX2&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2387?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2387      +/-   ##
   ============================================
   - Coverage     80.30%   80.27%   -0.03%     
     Complexity     1382     1382              
   ============================================
     Files          1560     1560              
     Lines         41569    41576       +7     
     Branches       3488     3489       +1     
   ============================================
   - Hits          33381    33375       -6     
   - Misses         6680     6692      +12     
   - Partials       1508     1509       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2387?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...che/servicecomb/serviceregistry/RegistryUtils.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2387/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L1JlZ2lzdHJ5VXRpbHMuamF2YQ==) | `79.10% <0.00%> (-2.44%)` | `0.00 <0.00> (ø)` | |
   | [...gistry/config/ServiceRegistryConfigCustomizer.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2387/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2NvbmZpZy9TZXJ2aWNlUmVnaXN0cnlDb25maWdDdXN0b21pemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...enterClient/ServerBServiceCenterConfiguration.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2387/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGVtby9kZW1vLW11bHRpLXNlcnZpY2UtY2VudGVyL2RlbW8tbXVsdGktc2VydmljZS1jZW50ZXItY2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9kZW1vL211bHRpU2VydmljZUNlbnRlckNsaWVudC9TZXJ2ZXJCU2VydmljZUNlbnRlckNvbmZpZ3VyYXRpb24uamF2YQ==) | `100.00% <100.00%> (ø)` | `2.00 <0.00> (ø)` | |
   | [...omb/transport/rest/client/RestTransportClient.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2387/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhbnNwb3J0cy90cmFuc3BvcnQtcmVzdC90cmFuc3BvcnQtcmVzdC1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL3RyYW5zcG9ydC9yZXN0L2NsaWVudC9SZXN0VHJhbnNwb3J0Q2xpZW50LmphdmE=) | `83.33% <0.00%> (-16.67%)` | `0.00% <0.00%> (ø%)` | |
   | [...mb/metrics/core/meter/os/cpu/AbstractCpuUsage.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2387/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0cmljcy9tZXRyaWNzLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL21ldHJpY3MvY29yZS9tZXRlci9vcy9jcHUvQWJzdHJhY3RDcHVVc2FnZS5qYXZh) | `88.88% <0.00%> (-11.12%)` | `0.00% <0.00%> (ø%)` | |
   | [...vicecomb/faultinjection/FaultInjectionHandler.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2387/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci1mYXVsdC1pbmplY3Rpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2ZhdWx0aW5qZWN0aW9uL0ZhdWx0SW5qZWN0aW9uSGFuZGxlci5qYXZh) | `80.95% <0.00%> (-4.77%)` | `0.00% <0.00%> (ø%)` | |
   | [.../servicecomb/registry/discovery/DiscoveryTree.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2387/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1yZWdpc3RyeS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvcmVnaXN0cnkvZGlzY292ZXJ5L0Rpc2NvdmVyeVRyZWUuamF2YQ==) | `96.49% <0.00%> (-3.51%)` | `0.00% <0.00%> (ø%)` | |
   | [...ache/servicecomb/foundation/common/net/IpPort.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2387/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2ZvdW5kYXRpb24vY29tbW9uL25ldC9JcFBvcnQuamF2YQ==) | `93.33% <0.00%> (+3.33%)` | `0.00% <0.00%> (ø%)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2387?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2387?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0eac3b2...572d767](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2387?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] codecov-commenter edited a comment on pull request #2387: [SCB-2267]add registryName api

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2387:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2387#issuecomment-843014401


   # [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2387?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2387](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2387?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1e79b02) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/0eac3b2f9d8ca95d7429cb589e1ea1e4ba27fe9d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0eac3b2) will **decrease** coverage by `0.01%`.
   > The diff coverage is `8.33%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2387/graphs/tree.svg?width=650&height=150&src=pr&token=KXfDcr9rX2&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2387?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2387      +/-   ##
   ============================================
   - Coverage     80.30%   80.28%   -0.02%     
     Complexity     1382     1382              
   ============================================
     Files          1560     1560              
     Lines         41569    41579      +10     
     Branches       3488     3490       +2     
   ============================================
     Hits          33381    33381              
   - Misses         6680     6690      +10     
     Partials       1508     1508              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2387?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...che/servicecomb/serviceregistry/RegistryUtils.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2387/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L1JlZ2lzdHJ5VXRpbHMuamF2YQ==) | `77.37% <0.00%> (-4.17%)` | :arrow_down: |
   | [...gistry/config/ServiceRegistryConfigCustomizer.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2387/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2NvbmZpZy9TZXJ2aWNlUmVnaXN0cnlDb25maWdDdXN0b21pemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...enterClient/ServerBServiceCenterConfiguration.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2387/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGVtby9kZW1vLW11bHRpLXNlcnZpY2UtY2VudGVyL2RlbW8tbXVsdGktc2VydmljZS1jZW50ZXItY2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9kZW1vL211bHRpU2VydmljZUNlbnRlckNsaWVudC9TZXJ2ZXJCU2VydmljZUNlbnRlckNvbmZpZ3VyYXRpb24uamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...thentication/consumer/RSAConsumerTokenManager.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2387/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci1wdWJsaWNrZXktYXV0aC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvYXV0aGVudGljYXRpb24vY29uc3VtZXIvUlNBQ29uc3VtZXJUb2tlbk1hbmFnZXIuamF2YQ==) | `70.96% <0.00%> (-6.46%)` | :arrow_down: |
   | [...ache/servicecomb/foundation/common/net/IpPort.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2387/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2ZvdW5kYXRpb24vY29tbW9uL25ldC9JcFBvcnQuamF2YQ==) | `93.33% <0.00%> (+3.33%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2387?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2387?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0eac3b2...1e79b02](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2387?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #2387: [SCB-2267]add registryName api

Posted by GitBox <gi...@apache.org>.
liubao68 commented on a change in pull request #2387:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2387#discussion_r634314091



##########
File path: service-registry/registry-service-center/src/main/java/org/apache/servicecomb/serviceregistry/RegistryUtils.java
##########
@@ -253,6 +253,9 @@ public static void executeOnEachServiceRegistry(Consumer<ServiceRegistry> action
 
   public static void addExtraServiceRegistry(ServiceRegistry serviceRegistry) {
     Objects.requireNonNull(serviceRegistry);
+    if (EXTRA_SERVICE_REGISTRIES.containsKey(serviceRegistry.getName())) {

Review comment:
       and name can not be the default regitry name




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] kaister3 commented on a change in pull request #2387: [SCB-2267]add registryName api

Posted by GitBox <gi...@apache.org>.
kaister3 commented on a change in pull request #2387:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2387#discussion_r634870804



##########
File path: service-registry/registry-service-center/src/main/java/org/apache/servicecomb/serviceregistry/RegistryUtils.java
##########
@@ -253,6 +253,9 @@ public static void executeOnEachServiceRegistry(Consumer<ServiceRegistry> action
 
   public static void addExtraServiceRegistry(ServiceRegistry serviceRegistry) {
     Objects.requireNonNull(serviceRegistry);
+    if (EXTRA_SERVICE_REGISTRIES.containsKey(serviceRegistry.getName())) {

Review comment:
       getName() here returns custom registry name, not default name




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] codecov-commenter edited a comment on pull request #2387: [SCB-2267]add registryName api

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2387:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2387#issuecomment-843014401


   # [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2387?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2387](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2387?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8cc88d8) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/0eac3b2f9d8ca95d7429cb589e1ea1e4ba27fe9d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0eac3b2) will **decrease** coverage by `0.01%`.
   > The diff coverage is `31.57%`.
   
   > :exclamation: Current head 8cc88d8 differs from pull request most recent head 7810101. Consider uploading reports for the commit 7810101 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2387/graphs/tree.svg?width=650&height=150&src=pr&token=KXfDcr9rX2&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2387?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2387      +/-   ##
   ============================================
   - Coverage     80.30%   80.28%   -0.02%     
     Complexity     1382     1382              
   ============================================
     Files          1560     1560              
     Lines         41569    41576       +7     
     Branches       3488     3489       +1     
   ============================================
   - Hits          33381    33380       -1     
   - Misses         6680     6687       +7     
   - Partials       1508     1509       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2387?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...che/servicecomb/serviceregistry/RegistryUtils.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2387/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L1JlZ2lzdHJ5VXRpbHMuamF2YQ==) | `76.25% <0.00%> (-5.28%)` | :arrow_down: |
   | [...gistry/config/ServiceRegistryConfigCustomizer.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2387/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2NvbmZpZy9TZXJ2aWNlUmVnaXN0cnlDb25maWdDdXN0b21pemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...enterClient/ServerBServiceCenterConfiguration.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2387/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGVtby9kZW1vLW11bHRpLXNlcnZpY2UtY2VudGVyL2RlbW8tbXVsdGktc2VydmljZS1jZW50ZXItY2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9kZW1vL211bHRpU2VydmljZUNlbnRlckNsaWVudC9TZXJ2ZXJCU2VydmljZUNlbnRlckNvbmZpZ3VyYXRpb24uamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...vicecomb/serviceregistry/client/IpPortManager.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2387/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2NsaWVudC9JcFBvcnRNYW5hZ2VyLmphdmE=) | `92.10% <100.00%> (+0.99%)` | :arrow_up: |
   | [...egistry/client/http/ServiceRegistryClientImpl.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2387/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2NsaWVudC9odHRwL1NlcnZpY2VSZWdpc3RyeUNsaWVudEltcGwuamF2YQ==) | `69.63% <100.00%> (+0.89%)` | :arrow_up: |
   | [...ache/servicecomb/foundation/common/net/IpPort.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2387/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2ZvdW5kYXRpb24vY29tbW9uL25ldC9JcFBvcnQuamF2YQ==) | `83.33% <0.00%> (-6.67%)` | :arrow_down: |
   | [.../servicecomb/registry/discovery/DiscoveryTree.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2387/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1yZWdpc3RyeS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvcmVnaXN0cnkvZGlzY292ZXJ5L0Rpc2NvdmVyeVRyZWUuamF2YQ==) | `96.49% <0.00%> (-3.51%)` | :arrow_down: |
   | [...e/archaius/sources/KieConfigurationSourceImpl.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2387/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHluYW1pYy1jb25maWcvY29uZmlnLWtpZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29uZmlnL2tpZS9hcmNoYWl1cy9zb3VyY2VzL0tpZUNvbmZpZ3VyYXRpb25Tb3VyY2VJbXBsLmphdmE=) | `65.30% <0.00%> (-2.05%)` | :arrow_down: |
   | [...mb/serviceregistry/client/http/RestClientUtil.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2387/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2NsaWVudC9odHRwL1Jlc3RDbGllbnRVdGlsLmphdmE=) | `77.57% <0.00%> (+1.86%)` | :arrow_up: |
   | ... and [2 more](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2387/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2387?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2387?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0eac3b2...7810101](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2387?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #2387: [SCB-2267]add registryName api

Posted by GitBox <gi...@apache.org>.
liubao68 commented on a change in pull request #2387:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2387#discussion_r634315237



##########
File path: service-registry/registry-service-center/src/main/java/org/apache/servicecomb/serviceregistry/RegistryUtils.java
##########
@@ -253,6 +253,9 @@ public static void executeOnEachServiceRegistry(Consumer<ServiceRegistry> action
 
   public static void addExtraServiceRegistry(ServiceRegistry serviceRegistry) {
     Objects.requireNonNull(serviceRegistry);
+    if (EXTRA_SERVICE_REGISTRIES.containsKey(serviceRegistry.getName())) {
+      throw new IllegalArgumentException("Register name duplicated!");

Review comment:
       reigstriy name {name} is duplicated between implementation {} and {}, please set different names for each implementation.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] kaister3 commented on a change in pull request #2387: [SCB-2267]add registryName api

Posted by GitBox <gi...@apache.org>.
kaister3 commented on a change in pull request #2387:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2387#discussion_r634865284



##########
File path: service-registry/registry-service-center/src/main/java/org/apache/servicecomb/serviceregistry/RegistryUtils.java
##########
@@ -253,6 +253,9 @@ public static void executeOnEachServiceRegistry(Consumer<ServiceRegistry> action
 
   public static void addExtraServiceRegistry(ServiceRegistry serviceRegistry) {
     Objects.requireNonNull(serviceRegistry);
+    if (EXTRA_SERVICE_REGISTRIES.containsKey(serviceRegistry.getName())) {
+      throw new IllegalArgumentException("Register name duplicated!");

Review comment:
       when duplicated, I can only get the new client name, cannot get old client name from EXTRA_SERVICE_REGISTRY. How to set different implmentation?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #2387: [SCB-2267]add registryName api

Posted by GitBox <gi...@apache.org>.
liubao68 commented on a change in pull request #2387:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2387#discussion_r634315237



##########
File path: service-registry/registry-service-center/src/main/java/org/apache/servicecomb/serviceregistry/RegistryUtils.java
##########
@@ -253,6 +253,9 @@ public static void executeOnEachServiceRegistry(Consumer<ServiceRegistry> action
 
   public static void addExtraServiceRegistry(ServiceRegistry serviceRegistry) {
     Objects.requireNonNull(serviceRegistry);
+    if (EXTRA_SERVICE_REGISTRIES.containsKey(serviceRegistry.getName())) {
+      throw new IllegalArgumentException("Register name duplicated!");

Review comment:
       reigstriy name {name} is duplicated, please set different names for each implementation.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org