You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by Pierre-Arnaud Marcelot <pa...@marcelot.net> on 2009/03/31 18:04:09 UTC
[Studio] [I18n] Internationalization not working for package
'org.apache.directory.studio.ldifeditor.dialogs.preferences'
Hi,
While reviewing the translation of Studio, I saw that classes under this
package 'org.apache.directory.studio.ldifeditor.dialogs.preferences' are not
correctly getting the translated strings in the 'messages_fr.properties' or
'messages_de.properties'. The English strings are used.
In the UI, it can be seen in the preferences, opening one of the pages under
'LDIF Editor' category.
If anyone has an idea?
Thanks,
Pierre-Arnaud
Re: [Studio] [I18n] Internationalization not working for package
'org.apache.directory.studio.ldifeditor.dialogs.preferences'
Posted by Felix Knecht <fe...@apache.org>.
>
> Maybe we should add the L10n report mentioned in [1] to find such things.
You can apply following patch
felix@donar ~/svn/apache/directory/studio/trunk $ svn diff pom.xml
Index: pom.xml
===================================================================
--- pom.xml (Revision 760330)
+++ pom.xml (Arbeitskopie)
@@ -1278,6 +1278,18 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
</plugin>
+ <plugin>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>l10n-maven-plugin</artifactId>
+ <version>1.0-alpha-2</version>
+ <configuration>
+ <locales>
+ <locale>en</locale>
+ <locale>de</locale>
+ <locale>fr</locale>
+ </locales>
+ </configuration>
+ </plugin>
</plugins>
</reporting>
and the run
"mvn l10n:report -Ddetail=true" in the trunk. If it fails there are some problems with the localization.
HTH
Felix
>
> Regards
> Felix
>
>
> [1] http://www.archivum.info/dev@directory.apache.org/2009-03/threads.html#00263
>> Thanks,
>> Pierre-Arnaud
>
Re: [Studio] [I18n] Internationalization not working for package
'org.apache.directory.studio.ldifeditor.dialogs.preferences'
Posted by Pierre-Arnaud Marcelot <pa...@marcelot.net>.
Hi Felix,
On Tue, Mar 31, 2009 at 6:34 PM, Felix Knecht <fe...@apache.org> wrote:
> At least the in messages_de.properties the german Umlauts are not encoded.
> Not sure if this is also the case for french
> translation and if it solves the problem, but in german translation it's a
> wrong.
I'll have a look at this. Thanks for this idea.
> Maybe we should add the L10n report mentioned in [1] to find such things.
>
+1 for that!
Thanks,
Pierre-Arnaud
Re: [Studio] [I18n] Internationalization not working for package
'org.apache.directory.studio.ldifeditor.dialogs.preferences'
Posted by Felix Knecht <fe...@apache.org>.
Pierre-Arnaud Marcelot schrieb:
> Hi,
>
> While reviewing the translation of Studio, I saw that classes under this
> package 'org.apache.directory.studio.ldifeditor.dialogs.preferences' are
> not correctly getting the translated strings in the
> 'messages_fr.properties' or 'messages_de.properties'. The English
> strings are used.
>
> In the UI, it can be seen in the preferences, opening one of the pages
> under 'LDIF Editor' category.
>
> If anyone has an idea?
At least the in messages_de.properties the german Umlauts are not encoded. Not sure if this is also the case for french
translation and if it solves the problem, but in german translation it's a wrong.
Maybe we should add the L10n report mentioned in [1] to find such things.
Regards
Felix
[1] http://www.archivum.info/dev@directory.apache.org/2009-03/threads.html#00263
>
> Thanks,
> Pierre-Arnaud
Re: [Studio] [I18n] Internationalization not working for package
Posted by Pierre-Arnaud Marcelot <pa...@marcelot.net>.
Thanks a lot Stefan !!!
Regards,
Pierre-Arnaud
On Wed, Apr 1, 2009 at 6:36 AM, Felix Knecht <fe...@apache.org> wrote:
> Big thanks to Stean for finding and fixing them!
> I just wonder why the L10n plugin didn't found them?
>
> Regards
> Felix
>
> Stefan Seelmann schrieb:
> > I fixed French and German characters.
> >
> > Here are the replacements:
> > \u00C4 Ä
> > \u00D6 Ö
> > \u00DC Ü
> > \u00E4 ä
> > \u00F6 ö
> > \u00FC ü
> > \u00DF ß
> > \u00E8 è
> > \u00E9 é
> > \u00E0 à
> > \u00FB û
> > \u00F9 ù
> > \u00EE î
> > \u00EA ê
> >
> > We could use the following regular expressions to find non-ascii
> characters:
> >
> > Eclipse search:
> > [^\x00-\x7F]
> >
> > Command line:
> > find . -name *.properties -exec grep -l -P [^\\x00-\\x7F] {} \;
> >
> > Kind Regards,
> > Stefan
> >
> >
> > Stefan Seelmann wrote:
> >> Pierre-Arnaud Marcelot wrote:
> >>> Thanks a lot Felix. It's now working.
> >>>
> >>> However, I've found 75 occurences of the 'ö' character in the
> >>> *_de.properties files.
> >>> I think we need a pass on accentuated characters in *.properties files
> >>> before the release to be sure we don't have a similar problem.
> >>>
> >> I guess that was me, I'll fix them, also all ÄÖÜäöüß.
> >>
> >> Regards,
> >> Stefan
> >
>
>
Re: [Studio] [I18n] Internationalization not working for package
Posted by Felix Knecht <fe...@apache.org>.
Big thanks to Stean for finding and fixing them!
I just wonder why the L10n plugin didn't found them?
Regards
Felix
Stefan Seelmann schrieb:
> I fixed French and German characters.
>
> Here are the replacements:
> \u00C4 Ä
> \u00D6 Ö
> \u00DC Ü
> \u00E4 ä
> \u00F6 ö
> \u00FC ü
> \u00DF ß
> \u00E8 è
> \u00E9 é
> \u00E0 à
> \u00FB û
> \u00F9 ù
> \u00EE î
> \u00EA ê
>
> We could use the following regular expressions to find non-ascii characters:
>
> Eclipse search:
> [^\x00-\x7F]
>
> Command line:
> find . -name *.properties -exec grep -l -P [^\\x00-\\x7F] {} \;
>
> Kind Regards,
> Stefan
>
>
> Stefan Seelmann wrote:
>> Pierre-Arnaud Marcelot wrote:
>>> Thanks a lot Felix. It's now working.
>>>
>>> However, I've found 75 occurences of the 'ö' character in the
>>> *_de.properties files.
>>> I think we need a pass on accentuated characters in *.properties files
>>> before the release to be sure we don't have a similar problem.
>>>
>> I guess that was me, I'll fix them, also all ÄÖÜäöüß.
>>
>> Regards,
>> Stefan
>
Re: [Studio] [I18n] Internationalization not working for package
'org.apache.directory.studio.ldifeditor.dialogs.preferences'
Posted by Stefan Seelmann <se...@apache.org>.
I fixed French and German characters.
Here are the replacements:
\u00C4 Ä
\u00D6 Ö
\u00DC Ü
\u00E4 ä
\u00F6 ö
\u00FC ü
\u00DF ß
\u00E8 è
\u00E9 é
\u00E0 à
\u00FB û
\u00F9 ù
\u00EE î
\u00EA ê
We could use the following regular expressions to find non-ascii characters:
Eclipse search:
[^\x00-\x7F]
Command line:
find . -name *.properties -exec grep -l -P [^\\x00-\\x7F] {} \;
Kind Regards,
Stefan
Stefan Seelmann wrote:
> Pierre-Arnaud Marcelot wrote:
>> Thanks a lot Felix. It's now working.
>>
>> However, I've found 75 occurences of the 'ö' character in the
>> *_de.properties files.
>> I think we need a pass on accentuated characters in *.properties files
>> before the release to be sure we don't have a similar problem.
>>
>
> I guess that was me, I'll fix them, also all ÄÖÜäöüß.
>
> Regards,
> Stefan
Re: [Studio] [I18n] Internationalization not working for package
'org.apache.directory.studio.ldifeditor.dialogs.preferences'
Posted by Stefan Seelmann <se...@apache.org>.
Pierre-Arnaud Marcelot wrote:
> Thanks a lot Felix. It's now working.
>
> However, I've found 75 occurences of the 'ö' character in the
> *_de.properties files.
> I think we need a pass on accentuated characters in *.properties files
> before the release to be sure we don't have a similar problem.
>
I guess that was me, I'll fix them, also all ÄÖÜäöüß.
Regards,
Stefan
Re: [Studio] [I18n] Internationalization not working for package
'org.apache.directory.studio.ldifeditor.dialogs.preferences'
Posted by Pierre-Arnaud Marcelot <pa...@marcelot.net>.
Here's an example:/apacheds/plugin_de.properties
I searched for this using Eclipse.
Regards,
Pierre-Arnaud
On Tue, Mar 31, 2009 at 7:17 PM, Felix Knecht <fe...@apache.org> wrote:
> Pierre-Arnaud Marcelot schrieb:
> > Thanks a lot Felix. It's now working.
> >
> > However, I've found 75 occurences of the 'ö' character in the
> > *_de.properties files.
> > I think we need a pass on accentuated characters in *.properties files
> > before the release to be sure we don't have a similar problem.
>
> I'm apologize, ut I can't find any 'ö':
> felix@donar ~/svn/apache/directory/studio/trunk $ grep -r -l ö . | grep
> de_\.properties
> felix@donar ~/svn/apache/directory/studio/trunk $
>
> Where and how did you found them? Are you sure that the search tool didn't
> cheated you by automatically doing the encoding?
>
> Regards
> Felix
>
Re: [Studio] [I18n] Internationalization not working for package
'org.apache.directory.studio.ldifeditor.dialogs.preferences'
Posted by Felix Knecht <fe...@apache.org>.
Pierre-Arnaud Marcelot schrieb:
> Thanks a lot Felix. It's now working.
>
> However, I've found 75 occurences of the 'ö' character in the
> *_de.properties files.
> I think we need a pass on accentuated characters in *.properties files
> before the release to be sure we don't have a similar problem.
I'm apologize, ut I can't find any 'ö':
felix@donar ~/svn/apache/directory/studio/trunk $ grep -r -l ö . | grep de_\.properties
felix@donar ~/svn/apache/directory/studio/trunk $
Where and how did you found them? Are you sure that the search tool didn't cheated you by automatically doing the encoding?
Regards
Felix
Re: [Studio] [I18n] Internationalization not working for package
'org.apache.directory.studio.ldifeditor.dialogs.preferences'
Posted by Pierre-Arnaud Marcelot <pa...@marcelot.net>.
Thanks a lot Felix. It's now working.
However, I've found 75 occurences of the 'ö' character in the
*_de.properties files.
I think we need a pass on accentuated characters in *.properties files
before the release to be sure we don't have a similar problem.
Regards,
P-A
On Tue, Mar 31, 2009 at 6:58 PM, Felix Knecht <fe...@apache.org> wrote:
>
> > In the UI, it can be seen in the preferences, opening one of the pages
> > under 'LDIF Editor' category.
>
> I found in both translations (de/fr) some encoding problems. Hope it's
> working now.
>
> Regards
> Felix
>
>
Re: [Studio] [I18n] Internationalization not working for package
'org.apache.directory.studio.ldifeditor.dialogs.preferences'
Posted by Felix Knecht <fe...@apache.org>.
> In the UI, it can be seen in the preferences, opening one of the pages
> under 'LDIF Editor' category.
I found in both translations (de/fr) some encoding problems. Hope it's working now.
Regards
Felix