You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Sijie Guo (JIRA)" <ji...@apache.org> on 2012/05/08 09:46:23 UTC

[jira] [Created] (BOOKKEEPER-241) Add documentation for bookie entry log compaction

Sijie Guo created BOOKKEEPER-241:
------------------------------------

             Summary: Add documentation for bookie entry log compaction
                 Key: BOOKKEEPER-241
                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-241
             Project: Bookkeeper
          Issue Type: Task
          Components: bookkeeper-server
    Affects Versions: 4.1.0
            Reporter: Sijie Guo
            Assignee: Sijie Guo
             Fix For: 4.1.0




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (BOOKKEEPER-241) Add documentation for bookie entry log compaction

Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BOOKKEEPER-241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sijie Guo updated BOOKKEEPER-241:
---------------------------------

    Attachment: BK-241.diff

add documents about compaction.
                
> Add documentation for bookie entry log compaction
> -------------------------------------------------
>
>                 Key: BOOKKEEPER-241
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-241
>             Project: Bookkeeper
>          Issue Type: Task
>          Components: bookkeeper-server
>    Affects Versions: 4.1.0
>            Reporter: Sijie Guo
>            Assignee: Sijie Guo
>             Fix For: 4.1.0
>
>         Attachments: BK-241.diff
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (BOOKKEEPER-241) Add documentation for bookie entry log compaction

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BOOKKEEPER-241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271189#comment-13271189 ] 

Hudson commented on BOOKKEEPER-241:
-----------------------------------

Integrated in bookkeeper-trunk #495 (See [https://builds.apache.org/job/bookkeeper-trunk/495/])
    BOOKKEEPER-241: Add documentation for bookie entry log compaction (sijie via fpj) (Revision 1335947)

     Result = SUCCESS
fpj : 
Files : 
* /zookeeper/bookkeeper/trunk/CHANGES.txt
* /zookeeper/bookkeeper/trunk/doc/bookieConfigParams.textile
* /zookeeper/bookkeeper/trunk/doc/bookkeeperOverview.textile

                
> Add documentation for bookie entry log compaction
> -------------------------------------------------
>
>                 Key: BOOKKEEPER-241
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-241
>             Project: Bookkeeper
>          Issue Type: Task
>          Components: bookkeeper-server
>    Affects Versions: 4.1.0
>            Reporter: Sijie Guo
>            Assignee: Sijie Guo
>             Fix For: 4.1.0
>
>         Attachments: BK-241.diff, BOOKKEEPER-241.patch, BOOKKEEPER-241.patch_v2
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (BOOKKEEPER-241) Add documentation for bookie entry log compaction

Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BOOKKEEPER-241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sijie Guo updated BOOKKEEPER-241:
---------------------------------

    Attachment: BOOKKEEPER-241.patch_v2

update a new patch based on Flavio's modification, which addressed Flavio's comment, changing 'negative value' to 'less than or equal to zero'.
                
> Add documentation for bookie entry log compaction
> -------------------------------------------------
>
>                 Key: BOOKKEEPER-241
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-241
>             Project: Bookkeeper
>          Issue Type: Task
>          Components: bookkeeper-server
>    Affects Versions: 4.1.0
>            Reporter: Sijie Guo
>            Assignee: Sijie Guo
>             Fix For: 4.1.0
>
>         Attachments: BK-241.diff, BOOKKEEPER-241.patch, BOOKKEEPER-241.patch_v2
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (BOOKKEEPER-241) Add documentation for bookie entry log compaction

Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BOOKKEEPER-241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271170#comment-13271170 ] 

Flavio Junqueira commented on BOOKKEEPER-241:
---------------------------------------------

+1, Thanks sijie.
                
> Add documentation for bookie entry log compaction
> -------------------------------------------------
>
>                 Key: BOOKKEEPER-241
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-241
>             Project: Bookkeeper
>          Issue Type: Task
>          Components: bookkeeper-server
>    Affects Versions: 4.1.0
>            Reporter: Sijie Guo
>            Assignee: Sijie Guo
>             Fix For: 4.1.0
>
>         Attachments: BK-241.diff, BOOKKEEPER-241.patch, BOOKKEEPER-241.patch_v2
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (BOOKKEEPER-241) Add documentation for bookie entry log compaction

Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BOOKKEEPER-241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Flavio Junqueira updated BOOKKEEPER-241:
----------------------------------------

    Attachment: BOOKKEEPER-241.patch

Hi Sijie, I have edited it a bit, please make sure I didn't break anything in this new patch. 

While reading it, I had a question: what if we set the compaction interval to zero? Do we have a check in place to make sure that it is not going to perform compaction continuously? On top of making sure the behavior is correct, it might be a good idea to update the documentation to reflect it.
                
> Add documentation for bookie entry log compaction
> -------------------------------------------------
>
>                 Key: BOOKKEEPER-241
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-241
>             Project: Bookkeeper
>          Issue Type: Task
>          Components: bookkeeper-server
>    Affects Versions: 4.1.0
>            Reporter: Sijie Guo
>            Assignee: Sijie Guo
>             Fix For: 4.1.0
>
>         Attachments: BK-241.diff, BOOKKEEPER-241.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (BOOKKEEPER-241) Add documentation for bookie entry log compaction

Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BOOKKEEPER-241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271022#comment-13271022 ] 

Sijie Guo commented on BOOKKEEPER-241:
--------------------------------------

@Flavio, thanks for editing the documents.

>  what if we set the compaction interval to zero? Do we have a check in place to make sure that it is not going to perform compaction continuously?

if the compaction interval is set to zero, the compaction would be disabled. there is code to check and disable it.

I would update the documents based your new patch.
                
> Add documentation for bookie entry log compaction
> -------------------------------------------------
>
>                 Key: BOOKKEEPER-241
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-241
>             Project: Bookkeeper
>          Issue Type: Task
>          Components: bookkeeper-server
>    Affects Versions: 4.1.0
>            Reporter: Sijie Guo
>            Assignee: Sijie Guo
>             Fix For: 4.1.0
>
>         Attachments: BK-241.diff, BOOKKEEPER-241.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira