You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/01/12 15:26:34 UTC

[jira] [Commented] (STORM-527) update worker.clj -- delete "missing-tasks" checking

    [ https://issues.apache.org/jira/browse/STORM-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14273640#comment-14273640 ] 

ASF GitHub Bot commented on STORM-527:
--------------------------------------

Github user BuDongDong commented on the pull request:

    https://github.com/apache/storm/pull/288#issuecomment-69576596
  
    @revans2 I have filed a JIRA(STORM-527) for this, please see https://issues.apache.org/jira/browse/STORM-527


> update worker.clj -- delete "missing-tasks" checking
> ----------------------------------------------------
>
>                 Key: STORM-527
>                 URL: https://issues.apache.org/jira/browse/STORM-527
>             Project: Apache Storm
>          Issue Type: Bug
>    Affects Versions: 0.9.3
>            Reporter: zhangjinlong
>            Assignee: zhangjinlong
>             Fix For: 0.9.3
>
>
> missing-tasks set is created by two times filter my-assignment map, so i think keys(my-assignment) contains missing-tasks set.
> missing-tasks is always empty. (empty? missing-tasks) always return true. 
> (let [missing-tasks (->> needed-tasks
>                                        (filter (complement my-assignment)))]
>                 (when-not (empty? missing-tasks)
>                   (log-warn "Missing assignment for following tasks: " (pr-str missing-tasks))
>                   ))
> https://github.com/apache/storm/commit/4b65d8152527f6770db6d103a7e2950f1a1f5f91



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)