You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/02/14 20:14:33 UTC

[GitHub] attilapiros commented on a change in pull request #23790: [SPARK-26792][CORE] Apply custom log URL to Spark UI

attilapiros commented on a change in pull request #23790: [SPARK-26792][CORE] Apply custom log URL to Spark UI
URL: https://github.com/apache/spark/pull/23790#discussion_r256992178
 
 

 ##########
 File path: core/src/test/scala/org/apache/spark/scheduler/CoarseGrainedSchedulerBackendSuite.scala
 ##########
 @@ -96,6 +100,10 @@ class CoarseGrainedSchedulerBackendSuite extends SparkFunSuite with LocalSparkCo
       override def onTaskEnd(taskEnd: SparkListenerTaskEnd): Unit = {
         taskEnded.set(true)
       }
+
+      override def onExecutorAdded(executorAdded: SparkListenerExecutorAdded): Unit = {
 
 Review comment:
   Please delete this method as not needed (inherited from SparkListener with the same body).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org