You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Erik van Oosten (JIRA)" <ji...@apache.org> on 2009/01/16 15:20:59 UTC
[jira] Created: (WICKET-2025) isVisible should not be called after
detach
isVisible should not be called after detach
-------------------------------------------
Key: WICKET-2025
URL: https://issues.apache.org/jira/browse/WICKET-2025
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.4-RC1
Reporter: Erik van Oosten
I think isVisible should not be called after detach to prevent model reloads.
I found one call to isVisible after detach in method ComponentRequestTarget#respond(RequestCycle). That method initiates a detach and then calls page.endComponentRender. This leads to a call to Page#checkRendering which calls isVisibleInHierarchy() and from there isVisible(). Method checkRendering only does something when the debug setting 'componentUseCheck' is enabled (which according to the javadoc is true by default).
Short term workaround: set debug setting 'componentUseCheck' to false.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2025) isVisible should not be called
after detach
Posted by "Martijn Dashorst (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12664528#action_12664528 ]
Martijn Dashorst commented on WICKET-2025:
------------------------------------------
This check is only enabled during development mode. It is turned off in deployment mode.
> isVisible should not be called after detach
> -------------------------------------------
>
> Key: WICKET-2025
> URL: https://issues.apache.org/jira/browse/WICKET-2025
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4-RC1
> Reporter: Erik van Oosten
>
> I think isVisible should not be called after detach to prevent model reloads.
> I found one call to isVisible after detach in method ComponentRequestTarget#respond(RequestCycle). That method initiates a detach and then calls page.endComponentRender. This leads to a call to Page#checkRendering which calls isVisibleInHierarchy() and from there isVisible(). Method checkRendering only does something when the debug setting 'componentUseCheck' is enabled (which according to the javadoc is true by default).
> Short term workaround: set debug setting 'componentUseCheck' to false.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-2025) isVisible should not be called after
detach
Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Juergen Donnerstag resolved WICKET-2025.
----------------------------------------
Resolution: Fixed
Fix Version/s: 1.4-RC2
Assignee: Juergen Donnerstag
thanks
> isVisible should not be called after detach
> -------------------------------------------
>
> Key: WICKET-2025
> URL: https://issues.apache.org/jira/browse/WICKET-2025
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4-RC1
> Reporter: Erik van Oosten
> Assignee: Juergen Donnerstag
> Fix For: 1.4-RC2
>
>
> I think isVisible should not be called after detach to prevent model reloads.
> I found one call to isVisible after detach in method ComponentRequestTarget#respond(RequestCycle). That method initiates a detach and then calls page.endComponentRender. This leads to a call to Page#checkRendering which calls isVisibleInHierarchy() and from there isVisible(). Method checkRendering only does something when the debug setting 'componentUseCheck' is enabled (which according to the javadoc is true by default).
> Short term workaround: set debug setting 'componentUseCheck' to false.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2025) isVisible should not be called
after detach
Posted by "Erik van Oosten (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12664533#action_12664533 ]
Erik van Oosten commented on WICKET-2025:
-----------------------------------------
In that case the javadoc of IDebugSettings needs an update. It does not change the importance of this issue.
> isVisible should not be called after detach
> -------------------------------------------
>
> Key: WICKET-2025
> URL: https://issues.apache.org/jira/browse/WICKET-2025
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4-RC1
> Reporter: Erik van Oosten
>
> I think isVisible should not be called after detach to prevent model reloads.
> I found one call to isVisible after detach in method ComponentRequestTarget#respond(RequestCycle). That method initiates a detach and then calls page.endComponentRender. This leads to a call to Page#checkRendering which calls isVisibleInHierarchy() and from there isVisible(). Method checkRendering only does something when the debug setting 'componentUseCheck' is enabled (which according to the javadoc is true by default).
> Short term workaround: set debug setting 'componentUseCheck' to false.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.