[GitHub] [superset] villebro commented on pull request #21032: fix(plugin-chart-echarts): invalid total label location for negative values in stacked bar chart

[GitBox <gi...@apache.org>]

villebro commented on PR #21032:
URL: https://github.com/apache/superset/pull/21032#issuecomment-1211593724

   > How does stacked bar chart work when a series group has a mix of negative and positive values? Is the total above the bars only the positive part or a sum of both positives and negatives?
   > 
   > Maybe we need to display both negative totals and positive totals separately, with positive totals on top of positive bars (if there are positive sums in a series) and negative totals below negative bars (if there are negatives).
   
   @ktmud I agree that the best way to stack when positive and negative values are present is to have the negative values stacked below the line and respectively the positive ones above the line. I have a slightly related fix that I need to get in that's related to bumping ECharts to 5.3.3, so I'll see if I can tackle that at the same time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org