[jira] [Commented] (MINIFICPP-715) RawSiteToSite: initiateResourceNegotiation functions returns success in case of uknown protocol

["Mr TheSegfault (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MINIFICPP-715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16748658#comment-16748658 ] 

Mr TheSegfault commented on MINIFICPP-715:
------------------------------------------

Yeah that looks like it's an oversight by the initial developer. It's unlikely a codec would not be negotiated that would end in failure; however, given the fact that we use one codec and one resource ( the standard ) this is a very explainable oversight.

 

I wonder if the developer expected this to have been a potentially recoverable transmission issue in the protocol(s). If so the documentation is light and there is no explanation yielding me to believe this could/should be changed in a future release. 

 

I think the change could be made, eventually, simply to improve readability of the code, but don't think it needs to be done this release. It's a pretty trivial change that should never be exercised as long as we use a single resource and codec. 

 

> RawSiteToSite: initiateResourceNegotiation functions returns success in case of uknown protocol
> -----------------------------------------------------------------------------------------------
>
>                 Key: MINIFICPP-715
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-715
>             Project: NiFi MiNiFi C++
>          Issue Type: Improvement
>            Reporter: Arpad Boda
>            Assignee: Arpad Boda
>            Priority: Trivial
>             Fix For: 0.7.0
>
>
>  
> _default:_
>  _logger_->log_warn("Negotiate protocol response unknown code %d", statusCode);_
>  _return true;_
>  _}_
>  
> The return value seems to be invalid in this case, this is not a happy path.
> [~phrocker] please confirm!
>  
> Update:
> The same issue seems to exist in 
> initiateCodecResourceNegotiation



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)