You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by persiaAziz <gi...@git.apache.org> on 2016/06/27 20:33:08 UTC
[GitHub] trafficserver pull request #750: Ts 3371
GitHub user persiaAziz opened a pull request:
https://github.com/apache/trafficserver/pull/750
Ts 3371
Adding a record.config variable for globally disabling/enabling session ticket
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/persiaAziz/trafficserver TS-3371
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/750.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #750
----
commit 554281133c5f401ba45f3bb205d57a7adacada31
Author: Syeda Aziz <pe...@kickedpredict.corp.ne1.yahoo.com>
Date: 2016-06-27T16:40:51Z
TS-3371: Programmatic disabling of SSL ticket use.
commit 36605288fb4a122937a7900ab6e2078769975fa0
Author: Syeda Aziz <pe...@yahoo-inc.com>
Date: 2016-06-27T20:01:01Z
Global session ticket disable
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #750: TS-3371 Add configuration to globally control usag...
Posted by persiaAziz <gi...@git.apache.org>.
Github user persiaAziz commented on the issue:
https://github.com/apache/trafficserver/pull/750
oops. I will make the default back to 1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #750: TS-3371 Add configuration to globally control usag...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/750
Also fix the merge conflicts and squash the commits down to one please :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #750: Ts 3371
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/750
Also, if the old default was "1", why did we change to "0" now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #750: TS-3371 Add configuration to globally control usag...
Posted by persiaAziz <gi...@git.apache.org>.
Github user persiaAziz commented on the issue:
https://github.com/apache/trafficserver/pull/750
proxy.config.ssl.server.session_ticket.enable makes much more sense to me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #750: TS-3371 Add configuration to globally contr...
Posted by shinrich <gi...@git.apache.org>.
Github user shinrich commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/750#discussion_r68771592
--- Diff: mgmt/RecordsConfig.cc ---
@@ -1212,6 +1212,8 @@ static const RecordElement RecordsConfig[] =
//##############################################################################
{RECT_CONFIG, "proxy.config.ssl.enabled", RECD_INT, "0", RECU_RESTART_TS, RR_NULL, RECC_INT, "[0-1]", RECA_NULL}
,
+ {RECT_CONFIG, "proxy.config.ssl.session.ticket.enabled", RECD_INT, "1", RECU_RESTART_TS, RR_NULL, RECC_INT, "[0-1]", RECA_NULL}
--- End diff --
I like proxy.config.ssl.server.ticket_key.enabled. I think you can enable/disable tickets on client side and server side, so I think it is good to be explicit in case we want to support client side changing advertising ticket capability.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #750: TS-3371 Add configuration to globally contr...
Posted by persiaAziz <gi...@git.apache.org>.
Github user persiaAziz closed the pull request at:
https://github.com/apache/trafficserver/pull/750
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #750: Ts 3371
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/750
Minor details, but
1) Can this be squashed into one commit?
2) Please update the Subject / Title of this PR accordingly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #750: Ts 3371
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/750
Also, the branch has merge conflicts, so please rebase with current master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---