You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/28 12:40:51 UTC

[GitHub] [airflow] kaxil commented on a change in pull request #15518: Adds interactivity when generating provider documentation.

kaxil commented on a change in pull request #15518:
URL: https://github.com/apache/airflow/pull/15518#discussion_r622138505



##########
File path: dev/provider_packages/prepare_provider_packages.py
##########
@@ -125,21 +125,20 @@ def cli():
     ...
 
 
-@cli.resultcallback()
-def process_result(result):
-    # This is special case - when the command executed returns false, it means that we are skipping
-    # the package
-    if result is False:
-        raise click.exceptions.Exit(64)
-    return result
-
-
 option_git_update = click.option(
     '--git-update/--no-git-update',
     default=True,
     is_flag=True,
     help=f"If the git remote {HTTPS_REMOTE} already exists, don't try to update it",
 )
+
+option_interactive = click.option(
+    '--interactive/--no-interactive',

Review comment:
       ```suggestion
       '--interactive/--non-interactive',
   ```
   
   Worth changing `--no-interactive` to `non-interactive` everywhere




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org