You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2022/07/23 07:39:19 UTC
[GitHub] [zeppelin] yaini commented on a diff in pull request #4419: [ZEPPELIN-5773] Fix isWindowsPath Function in ZeppelinConfiguration class
yaini commented on code in PR #4419:
URL: https://github.com/apache/zeppelin/pull/4419#discussion_r928092112
##########
zeppelin-interpreter/src/main/java/org/apache/zeppelin/conf/ZeppelinConfiguration.java:
##########
@@ -636,8 +633,12 @@ public String getInterpreterPortRange() {
return getString(ConfVars.ZEPPELIN_INTERPRETER_RPC_PORTRANGE);
}
- public boolean isWindowsPath(String path){
- return path.matches("^[A-Za-z]:\\\\.*");
+ public boolean isWindowsCheck(){
Review Comment:
nitpick) How about `isWindowsOS`? It would be better to specify what to check.
##########
zeppelin-interpreter/src/main/java/org/apache/zeppelin/conf/ZeppelinConfiguration.java:
##########
@@ -636,8 +633,12 @@ public String getInterpreterPortRange() {
return getString(ConfVars.ZEPPELIN_INTERPRETER_RPC_PORTRANGE);
}
- public boolean isWindowsPath(String path){
- return path.matches("^[A-Za-z]:\\\\.*");
+ public boolean isWindowsCheck(){
Review Comment:
nitpick) How about `isWindowsOS`? It would be better to specify what to check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org