You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2017/05/08 21:26:33 UTC
[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build.
......................................................................
Patch Set 7:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5715/7/be/src/kudu/util/compression/compression_codec.cc
File be/src/kudu/util/compression/compression_codec.cc:
Line 28: #ifdef DISALLOW_COPY_AND_ASSIGN
Maybe comment that snappy.h redefines this so that we don't lose track of why this is here.
http://gerrit.cloudera.org:8080/#/c/5715/7/be/src/kudu/util/status.h
File be/src/kudu/util/status.h:
Line 122: #ifndef KUDU_LOG
Is this still needed? I don't see how this can get defined twice.
--
To view, visit http://gerrit.cloudera.org:8080/5715
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8da798ee55506d6f969416b17c191eb03cb215f5
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes