You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/10/05 20:07:15 UTC
[GitHub] [airflow] jedcunningham commented on a diff in pull request #24588: add: container securityContext not available in podSecurityContext
jedcunningham commented on code in PR #24588:
URL: https://github.com/apache/airflow/pull/24588#discussion_r985964043
##########
chart/values.schema.json:
##########
@@ -1608,21 +1689,65 @@
}
],
"$ref": "#/definitions/io.k8s.api.core.v1.ResourceRequirements"
+ },
+ "containerSecurityContext": {
+ "description": "Container security context definition. The values in this parameter will be used when `containerSecurityContext` is not defined for specific Containers",
+ "type": "object",
+ "$ref": "#/definitions/io.k8s.api.core.v1.SecurityContext",
+ "default": {
+ "runAsUser": 0
+ },
+ "x-docsSection": "Kubernetes",
+ "examples": [
+ {
+ "allowPrivilegeEscalation": false,
+ "capabilities": {
+ "drop": [
+ "ALL"
+ ]
+ }
+ }
+ ]
}
}
},
- "securityContext": {
Review Comment:
We need to leave these old deprecated ones in the schema also, otherwise helm won't allow you to actually deploy any longer.
Might be worth adding a test or 2 to cover the old ones to make sure they keep working.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org