You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "treblereel (via GitHub)" <gi...@apache.org> on 2024/05/06 01:43:34 UTC
[PR] SRVLOGIC-289: Remove workflow plugin dependency on knative/client int… [incubator-kie-tools]
treblereel opened a new pull request, #2293:
URL: https://github.com/apache/incubator-kie-tools/pull/2293
…erface
(cherry picked from commit dc7a3ecbcf65c835b0963e273c8a2308581e73d1)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] NO-ISSUE: Remove workflow plugin dependency on knative/client int… [incubator-kie-tools]
Posted by "domhanak (via GitHub)" <gi...@apache.org>.
domhanak commented on PR #2293:
URL: https://github.com/apache/incubator-kie-tools/pull/2293#issuecomment-2097614467
@tomasdavidorg fyi, want to check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] NO-ISSUE: Remove workflow plugin dependency on knative/client int… [incubator-kie-tools]
Posted by "treblereel (via GitHub)" <gi...@apache.org>.
treblereel commented on PR #2293:
URL: https://github.com/apache/incubator-kie-tools/pull/2293#issuecomment-2115996341
It looks like CI is broke, https://github.com/apache/incubator-kie-tools/pull/2339
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] NO-ISSUE: Remove workflow plugin dependency on knative/client int… [incubator-kie-tools]
Posted by "treblereel (via GitHub)" <gi...@apache.org>.
treblereel commented on PR #2293:
URL: https://github.com/apache/incubator-kie-tools/pull/2293#issuecomment-2116000491
@tiagobento yeap, let me do a separate PR for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] NO-ISSUE: Remove workflow plugin dependency on knative/client int… [incubator-kie-tools]
Posted by "treblereel (via GitHub)" <gi...@apache.org>.
treblereel commented on PR #2293:
URL: https://github.com/apache/incubator-kie-tools/pull/2293#issuecomment-2111521908
hmm,
```
packages/kogito-serverless-operator build:dev: ./hack/goimports.sh
packages/kogito-serverless-operator build:dev: Windows Subsystem for Linux has no installed distributions.
packages/kogito-serverless-operator build:dev: Distributions can be installed by visiting the Microsoft Store:
packages/kogito-serverless-operator build:dev: https://aka.ms/wslstore
```
not sure it's related to this pr, but lets take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] NO-ISSUE: Remove workflow plugin dependency on knative/client int… [incubator-kie-tools]
Posted by "caponetto (via GitHub)" <gi...@apache.org>.
caponetto commented on PR #2293:
URL: https://github.com/apache/incubator-kie-tools/pull/2293#issuecomment-2102296081
@treblereel The CI on Windows has failed. Could you please check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] NO-ISSUE: Remove workflow plugin dependency on knative/client int… [incubator-kie-tools]
Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento merged PR #2293:
URL: https://github.com/apache/incubator-kie-tools/pull/2293
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] NO-ISSUE: Remove workflow plugin dependency on knative/client int… [incubator-kie-tools]
Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento commented on PR #2293:
URL: https://github.com/apache/incubator-kie-tools/pull/2293#issuecomment-2115995770
@treblereel I saw you made #2339, which is a great test. I went looking into the changes of this PR and indeed there was no indication that the changes were related with the failure.
Because you changed `kn-plugin-workflow`, all dependencies are built with `build:dev` (ignoring tests, linters etc). However, the `kogito-serverless-operator` package is configured with a command for Windows that doesn't seem to work. If you look at the `build:prod` command, the build is skipped.
Please change `build:dev:win32` to `"build:dev:win32": "echo 'Build not supported on Windows'",`, so the `kogito-serverless-operator` package is also not built on Windows in development mode.
Sorry for the inconvenience! And great idea of sending this separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org